Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66398

Improve H5P filter to allow internal H5P content URLs

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      Check in Site administration > Plugins > Filters > Manage filters 'H5P filter' is enabled and applied before 'Convert URLs into links and images' and 'Activity names auto-linking' filters.

      To test this issue, and because is blocked by MDL-66609, you need to have all the commits in that issue, or wait till the issue has been integrated.

      Testing

      1. As an admin navigate to 'Private files'
      2. Create a folder with spaces in the name, e.g. "Folder with spaces".
      3. Upload 'arithmetic-quiz-22-57860 (1)' file to the folder
      4. Navigate to Dashboard. Add 'Private files' block to your Dashboard.
      5. Copy link address to 'arithmetic-quiz-22-57860 (1)' file
      6. In a course create a new label.
      7. Add link address to 'arithmetic-quiz-22-57860 (1)' file to 'Label text'
      8. Save and return to course.
      9. Make sure H5P content is rendered and working (remember commits from MDL-66609 are needed for the content to be rendered)
      Show
      Setup Check in Site administration > Plugins > Filters > Manage filters 'H5P filter' is enabled and applied before 'Convert URLs into links and images' and 'Activity names auto-linking' filters. To test this issue, and because is blocked by  MDL-66609 , you need to have all the commits in that issue, or wait till the issue has been integrated . Testing As an admin navigate to 'Private files' Create a folder with spaces in the name, e.g. "Folder with spaces". Upload 'arithmetic-quiz-22-57860 (1)' file to the folder Navigate to Dashboard. Add 'Private files' block to your Dashboard. Copy link address to 'arithmetic-quiz-22-57860 (1)' file In a course create a new label. Add link address to 'arithmetic-quiz-22-57860 (1)' file to 'Label text' Save and return to course. Make sure H5P content is rendered and working (remember commits from  MDL-66609  are needed for the content to be rendered)
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66398-master
    • Sprint:
      H5P Sprint 3, H5P Sprint Relase 3.8

      Description

      For URLs like https://moodlesite/h5p/id=?xx or https://moodlesite/h5p/embed.php?id=xx the button should add the HTML code above:

       

      <iframe src="https://moodlesite/h5p/embed.php?url=xx&export=1&embed=1"  class="h5p-iframe" style="height: 518px; width: 100%; border: 0px;" allowfullscreen="allowfullscreen"></iframe><script src="https://xxx.h5p.com/js/h5p-resizer.js" charset="UTF-8"></script>

      Tasks:

      • Improve filter to convert internal H5P content from the content bank

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              amaia Amaia Anabitarte
              Reporter:
              amaia Amaia Anabitarte
              Peer reviewer:
              Víctor Déniz Falcón
              Integrator:
              Andrew Nicols
              Tester:
              Ferran Recio
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 3 hours, 37 minutes
                  2w 3h 37m