Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66398

Improve H5P filter to allow internal H5P content URLs

    XMLWordPrintable

Details

    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-66398-master
    • Hide

      Setup

      Check in Site administration > Plugins > Filters > Manage filters 'H5P filter' is enabled and applied before 'Convert URLs into links and images' and 'Activity names auto-linking' filters.

      To test this issue, and because is blocked by MDL-66609, you need to have all the commits in that issue, or wait till the issue has been integrated.

      Testing

      1. As an admin navigate to 'Private files'
      2. Create a folder with spaces in the name, e.g. "Folder with spaces".
      3. Upload 'arithmetic-quiz-22-57860 (1)' file to the folder
      4. Navigate to Dashboard. Add 'Private files' block to your Dashboard.
      5. Copy link address to 'arithmetic-quiz-22-57860 (1)' file
      6. In a course create a new label.
      7. Add link address to 'arithmetic-quiz-22-57860 (1)' file to 'Label text'
      8. Save and return to course.
      9. Make sure H5P content is rendered and working (remember commits from MDL-66609 are needed for the content to be rendered)
      Show
      Setup Check in Site administration > Plugins > Filters > Manage filters 'H5P filter' is enabled and applied before 'Convert URLs into links and images' and 'Activity names auto-linking' filters. To test this issue, and because is blocked by  MDL-66609 , you need to have all the commits in that issue, or wait till the issue has been integrated . Testing As an admin navigate to 'Private files' Create a folder with spaces in the name, e.g. "Folder with spaces". Upload 'arithmetic-quiz-22-57860 (1)' file to the folder Navigate to Dashboard. Add 'Private files' block to your Dashboard. Copy link address to 'arithmetic-quiz-22-57860 (1)' file In a course create a new label. Add link address to 'arithmetic-quiz-22-57860 (1)' file to 'Label text' Save and return to course. Make sure H5P content is rendered and working (remember commits from  MDL-66609  are needed for the content to be rendered)
    • H5P Sprint 3, H5P Sprint Relase 3.8

    Description

      For URLs like https://moodlesite/h5p/id=?xx or https://moodlesite/h5p/embed.php?id=xx the button should add the HTML code above:

       

      <iframe src="https://moodlesite/h5p/embed.php?url=xx&export=1&embed=1"  class="h5p-iframe" style="height: 518px; width: 100%; border: 0px;" allowfullscreen="allowfullscreen"></iframe><script src="https://xxx.h5p.com/js/h5p-resizer.js" charset="UTF-8"></script>

      Tasks:

      • Improve filter to convert internal H5P content from the content bank

      Attachments

        Issue Links

          blocks

          New Feature - A new Moodle feature which has yet to be developed. MOBILE-2235 Initial H5P support

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-66399 Improve H5P Atto button to upload content

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-66405 New behat tests for H5P tools

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66954 Rename filter_h5p to filter_displayh5p

          • Major - Major loss of function, incorrect output
          • Closed

          New Feature - A new Moodle feature which has yet to be developed. MDL-66397 Create a new filter to convert h5p.com and h5p.org urls to embed code

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-66402 Create renderer for deploying and displaying H5P content

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-66609 Create the basic skeleton, library and interfaces for rendering H5P content

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-67083 Escape possible regex delimiters in 'allowedsources' setting for H5P

          • Minor - Minor loss of function where workaround is possible
          • Open

          Activity

            People

              amaia Amaia Anabitarte
              amaia Amaia Anabitarte
              Victor Déniz Falcón Victor Déniz Falcón
              Andrew Lyons Andrew Lyons
              Ferran Recio Ferran Recio
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 3 hours, 37 minutes
                  2w 3h 37m