[MDL-66450] User data label should wrap in enrol users modal window - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.5, 3.7, 3.8
Fix Version/s: 3.6.7, 3.7.3
Component/s: Enrolments, HTML and CSS
Labels:
- UX
- ci
- release_notes
- triaged

Testing Instructions:
Hide

Please test on Boost for version master and Clean for version 3.6. Test on RTL too!

Login as admin.

Create a new user with a really long first name and lastname

Create a new course c1

Navigate to Participants

Click the enrol user button

In the Enrol users modal click the select users input field

Find your new user and click the user when found

Verify that when the user has been selected the user is displayed in a label and the text for the label wraps if it is too long.
Show
Please test on Boost for version master and Clean for version 3.6. Test on RTL too! Login as admin. Create a new user with a really long first name and lastname Create a new course c1 Navigate to Participants Click the enrol user button In the Enrol users modal click the select users input field Find your new user and click the user when found Verify that when the user has been selected the user is displayed in a label and the text for the label wraps if it is too long.
Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull 3.7 Branch:
~~MDL-66450~~-37
Pull 3.7 Diff URL:
https://github.com/bmbrands/moodle/compare/8b89ab5798...MDL-66450-37
Pull Master Branch:
~~MDL-66450~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/6ec1078469...MDL-66450-master

Description

When enrolling users, particularly on smaller screens or if they have long names or lots of other data, the label styles apply white-space: nowrap which means the content spills off the side of the modal. (See screenshot)

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

Screen Shot 2019-08-20 at 15.14.45.png
144 kB
20/Aug/19 10:25 PM
Screen Shot 2019-08-20 at 15.14.17.png
56 kB
20/Aug/19 10:26 PM
image-2019-09-22-12-08-36-843.png
223 kB
22/Sep/19 6:08 PM
36_Clean_FAILED.PNG
36 kB
10/Oct/19 1:04 PM
36_Clean__RTL_FAILED.PNG
36 kB
10/Oct/19 1:04 PM
Confirmed and verified.png
277 kB
11/Oct/19 12:53 PM

Issue Links

duplicates

MDL-60879 Review styling when extra fields are added to users suggestion list

Open

Activity

People

Assignee:: Bas Brands

Reporter:: David Scotson

Peer reviewer:: Luca Bösch

Integrator:: Jun Pataleta

Tester:: Gladys Basiana

Participants:: Amaia Anabitarte, Bas Brands, CiBoT, David Scotson, Eloy Lafuente (stronk7), Gladys Basiana, Helen Foster, Jun Pataleta, Luca Bösch

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 20/Aug/19 10:24 PM

Updated:: 05/Nov/19 3:20 AM

Resolved:: 12/Oct/19 5:13 AM

Fix Release Date:: 11/Nov/19

Time Tracking

Estimated:

Remaining:

Logged:

3h 15m