Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66483

Avoid xmlize dependency on setuplib

    XMLWordPrintable

    Details

      Description

      This is a fix for a recently introduced regression @ MDL-66110.

      Exception - Notice: Undefined variable: CFG in [dirroot]/lib/xmlize.php on line 43
       
      More information about this error
       
      ×Debug info: 
      Error code: generalexceptionmessage
      ×Stack trace:
      line 158 of /lib/behat/lib.php: Exception thrown
      line 43 of /lib/xmlize.php: call to behat_error_handler()
      line 2428 of /mod/glossary/lib.php: call to require_once()
      line 84 of /mod/glossary/import.php: call to glossary_read_imported_file()
      

      Aiming to fix a problem with one of our CI tests... we added a dependency on xmlize to require setuplib that needs CFG to be around.

      This just reverts that commit, keeping things like they were previously and also fixes the glossary case, where the global CFG should be the very first line.

      The CI job will be fixed separately to this (will comment once is ready).

      Ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Jun Pataleta
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 3 minutes
                  1h 3m