[MDL-66493] readstring_accel should not use xsendfile via get_file_storage() - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_37_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull Master Branch:
~~MDL-66493~~-readstring_accel
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/9f997f9b...brendanheywood:MDL-66493-readstring_accel
Testing Instructions:
Hide

1) On a plain moodle make a test file:

<?php

require('config.php');

readstring_accel('hello world', 'text/plain', 1);

2) Run this in a browser, it should say hello world

3) Setup xsendfile. This can be a real setup or even a wrong broken one ie set the header without the apache / nginx module being configured:

config.php:

$CFG->xsendfile = 'X-Sendfile';

4) Re-run the test file again. It should still say hello world
Show
1) On a plain moodle make a test file: <?php require( 'config.php' ); readstring_accel( 'hello world' , 'text/plain' , 1 ); 2) Run this in a browser, it should say hello world 3) Setup xsendfile. This can be a real setup or even a wrong broken one ie set the header without the apache / nginx module being configured: config.php: $CFG->xsendfile = 'X-Sendfile'; 4) Re-run the test file again. It should still say hello world

In various places in moodle we send a temp file which is not inside the filedir

But some of these files are not in get_file_storage() and might be in temp, so sending a sha1 hash and pretending the file is filedir is wrong.

has been marked as being related by

MDL-66304 Allow support for xsendfile in alternative_file_system_class independently of local files

Participants:: Adrian Greeve, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Jake Dallimore, Matteo Scaramuccia, Matt Porritt

Component watchers:: Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

2h 40m