Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66502

Moodle 3.8 does not load javascript files from previous moodle versions

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to "Site administration / Appearance / AJAX and Javascript" and make sure that Cache Javascript (cachejs) is enabled.
      3. Download and install the attached test block ( block_counter.zip )
      4. Add the "Counter" block to a page (e.g. in any course page or your dashboard)
      5. Confirm that the number increments inside the counter block.
      6. Repeat the test with "cachejs" disabled and confirm that the number still increments.
      Show
      Log in as admin Go to " Site administration / Appearance / AJAX and Javascript " and make sure that Cache Javascript (cachejs) is enabled. Download and install the attached test block ( block_counter.zip ) Add the "Counter" block to a page (e.g. in any course page or your dashboard) Confirm that the number increments inside the counter block. Repeat the test with " cachejs " disabled and confirm that the number still increments.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66502-master
    • Story Points:
      1
    • Sprint:
      Sprint 6 - Looney Tunes

      Description

      When calling an amd module on moodle 3.8 which was minified using a previous moodle version, the javascript doesn't get loaded and I get the following error in the console:

      Error: No define call for lifecyclestep_adminapprove/link-steps
      http://requirejs.org/docs/errors.html#nodefine

      To test it, you can use the 'Test plugin from previous version of Moodle' testing instruction from MDL-62497 .

      It seems not to be the fault of the block_counter, since javascript also didn't work in two other plugins when minified using a previous moodle version, but they all work when the javascript is minified using moodle38.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              justusdieckmann Justus Dieckmann
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 5 minutes
                  1h 5m