[MDL-66532] Add .nvmrc to ensure it is consistent - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.7, 3.6.5, 3.7.1, 3.8
Fix Version/s: 3.5.8, 3.6.6, 3.7.2
Component/s: JavaScript
Labels:
- ci
- dev_docs_required

Testing Instructions:
Hide

Ensure that you have the correct version of NPM/Node installed...

If you are using NVM, then you can now just run:

nvm use

If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1)

Remove your existing node_modules directory.

Install your mode modules:

npm cache clear --force

npm install

Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one

Rejoice!
Show
Ensure that you have the correct version of NPM/Node installed... If you are using NVM, then you can now just run: nvm use If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1) Remove your existing node_modules directory. Install your mode modules: npm cache clear --force npm install Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one Rejoice!
Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.5 Branch:
~~MDL-66532~~-35
Pull 3.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/de168198e6...MDL-66532-35
Pull 3.6 Branch:
~~MDL-66532~~-36
Pull 3.6 Diff URL:
https://github.com/andrewnicols/moodle/compare/5f5e77c4ef...MDL-66532-36
Pull 3.7 Branch:
~~MDL-66532~~-37
Pull 3.7 Diff URL:
https://github.com/andrewnicols/moodle/compare/684d142401...MDL-66532-37
Pull Master Branch:
~~MDL-66532~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/0dca957716...MDL-66532-master

Description

From what I understand we should be using a package-lock.json rather than the existing npm-shrinkwrap.json.

The lock variant will only be updated when adding, removing, or upgrading packages; whilst the shrinkwrap is updated on each npm install.

Attachments

Issue Links

blocks

MDL-66265 Update jshint and add ignore

Closed

has a non-specific relationship to

MDL-66109 Bump nodejs from lts/carbon to lts/dubnium (>=v10.16.0)

Open

MDLSITE-5931 Move all local_ci stuff to work with both shrinkwrap.json and package-lock.json

Open

MDLSITE-5536 New CI job to look for changes in lock files

Open

Activity

People

Assignee:

Andrew Nicols

Reporter:

Andrew Nicols

Peer reviewer:

Mathew May

Integrator:

Eloy Lafuente (stronk7)

Tester:

Ryan Wyllie

Participants:

Andrew Nicols, CiBoT, Eloy Lafuente (stronk7), Mathew May, Ryan Wyllie

Component watchers:

Jake Dallimore, Jun Pataleta

Votes:

1 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

28/Aug/19 8:21 AM

Updated:

06/Sep/19 12:30 AM

Resolved:

06/Sep/19 12:30 AM

Fix Release Date:

9/Sep/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 25m