Loading...

XML

Word

Printable

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-66532~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/0dca957716...MDL-66532-master
Testing Instructions:
Hide

Ensure that you have the correct version of NPM/Node installed...

If you are using NVM, then you can now just run:

nvm use

If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1)

Remove your existing node_modules directory.

Install your mode modules:

npm cache clear --force

npm install

Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one

Rejoice!
Show
Ensure that you have the correct version of NPM/Node installed... If you are using NVM, then you can now just run: nvm use If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1) Remove your existing node_modules directory. Install your mode modules: npm cache clear --force npm install Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one Rejoice!

From what I understand we should be using a package-lock.json rather than the existing npm-shrinkwrap.json.

The lock variant will only be updated when adding, removing, or upgrading packages; whilst the shrinkwrap is updated on each npm install.

blocks

MDL-66265 Update jshint and add ignore

has a non-specific relationship to

MDL-66109 Bump nodejs from lts/carbon to stable (>=v14.0.0)

MDLSITE-5931 Move all local_ci stuff to work with both shrinkwrap.json and package-lock.json

MDLSITE-5536 New CI job to look for changes in lock files

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Mathew May, Ryan Wyllie

Estimated:

Not Specified

Remaining:

Logged:

2h 25m