Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66532

Add .nvmrc to ensure it is consistent

    XMLWordPrintable

Details

    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • MDL-66532-master
    • Hide
      1. Ensure that you have the correct version of NPM/Node installed...
        1. If you are using NVM, then you can now just run: 

          nvm use

        2. If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1)
      2. Remove your existing node_modules directory.
      3. Install your mode modules: 

        npm cache clear --force
        		 
        npm install

      4. Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one
      5. Rejoice!
      Show
      Ensure that you have the correct version of NPM/Node installed... If you are using NVM, then you can now just run: nvm use If you are not... go and install NVM and the run step 1.1 (or install the latest version of the Carbon LTS release - v8.16.1) Remove your existing node_modules directory. Install your mode modules: npm cache clear --force npm install Confirm that the npm-shrinkwrap.json exists and it's the same than upstream one Rejoice!

    Description

      From what I understand we should be using a package-lock.json rather than the existing npm-shrinkwrap.json.

      The lock variant will only be updated when adding, removing, or upgrading packages; whilst the shrinkwrap is updated on each npm install.

      Attachments

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-66265 Update jshint and add ignore

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66109 Bump nodejs from lts/carbon to stable (>=v14.0.0)

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-5931 Move all local_ci stuff to work with both shrinkwrap.json and package-lock.json

          • Low - Cosmetic problems, nice-to-have features
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-5536 New CI job to look for changes in lock files

          • Low - Cosmetic problems, nice-to-have features
          • Open

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Mathew May Mathew May
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Ryan Wyllie Ryan Wyllie
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 25 minutes
                  2h 25m