-
Improvement
-
Resolution: Fixed
-
Minor
-
3.7
-
MOODLE_37_STABLE
-
MOODLE_38_STABLE
-
MDL-66537-master -
Prerequisites:
# A course with a student enrolled
- An assignment in the course with annotation enabled as a feedback method
- An RTL language pack installed(Follow instructions here)
Testing:
- Login as a teacher
- Go to the assignment within the course
- Go to the grading table.
- Select the 'Grade' button against the student (Open in a new tab - Tab2)
- Confirm that the button order is "Rotate left; Rotate right":
- Confirm that the button order is "Rotate left; Rotate right":
- In Tab1, Switch to the RTL language
- Refresh Tab2 and confirm the rotate left / right buttons' position appear unchanged. Refer
for expected behaviour
- Confirm that the button order is NOT "Rotate right; Rotate left":
- Confirm that the button order is NOT "Rotate right; Rotate left":
Prerequisites: # A course with a student enrolled An assignment in the course with annotation enabled as a feedback method An RTL language pack installed(Follow instructions here ) Testing: Login as a teacher Go to the assignment within the course Go to the grading table. Select the 'Grade' button against the student (Open in a new tab - Tab2) Confirm that the button order is "Rotate left; Rotate right" : In Tab1, Switch to the RTL language Refresh Tab2 and confirm the rotate left / right buttons' position appear unchanged. Refer for expected behaviour Confirm that the button order is NOT "Rotate right; Rotate left" :
Please note that this bug relates only to Right-to-left UI environments.
Repro Steps
- Login to the Moodle environment
- Switch to the English UI.
- Login as a teacher and create an assignment.
- Login as a student and submit a document.
- Login again as a teacher, enter the assignment and the submissions table, and click the "Grade"button at the row of the student that submitted the document.
- Play a little bit with the rotate buttons to see what each one does, in case the icons are not clear enough
Actual Results
The "Rotate 90 degrees to the right" button is the left one, and the "Rotate 90 degrees to the left" button is the right one.
While still usable, this is counter-intuitive and confusing.
Expected Results
The "Rotate 90 degrees to the right" button should be the right one, and the "Rotate 90 degrees to the left" button should be the left one.
Right-to-left (RTL) UI shouldn't always be an exact mirror of the Left-to-right UI, and this is a good example for that.
