[MDL-66542] "quote" Mustache helper only escapes first quote in JS - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/t-schroeder/moodle
Pull Main Branch:
~~MDL-66542~~_master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/moodle:master...t-schroeder:MDL-66542_master
Testing Instructions:
Hide

Login as Manager.

Add upcoming_events block to your dashboard.

Create assignment in one of your courses with:

Due date: tomorrow

Name: Double "quote" test

Go to the dashboard.
=> You don't get a syntax error dialog.
Show
Login as Manager. Add upcoming_events block to your dashboard. Create assignment in one of your courses with: Due date: tomorrow Name: Double "quote" test Go to the dashboard. => You don't get a syntax error dialog.

The JS variant of the "quote" Mustache helper only escapes the first double quote in the string. Responsible for that is this call: https://github.com/moodle/moodle/blob/0dca957716952323bd56089929ac6412136a29f1/lib/amd/src/templates.js#L487

Steps to reproduce the problem:

Login as Manager.
Add upcoming_events block to your dashboard.
Create assignment in one of your courses with:
- Due date: tomorrow
- Name: Double "quote" test
Go to the dashboard.
=> You get a Syntax error "Unexpected token t in JSON at position 27".

caused a regression

MDL-66820 Double escaped quotes in timeline block

is a regression caused by

MDL-52136 User fullname or course shortname with double quote breaks forum emails

Participants:: Bas Brands, CiBoT, Eloy Lafuente (stronk7), Eric Merrill, Gladys Basiana, Misael Bandeira Silveira, Tim Schroeder

Estimated:

Remaining:

Logged:

55m