[MDL-66552] Move and rename relativedatestimediffformat lang string - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8
Fix Version/s: 3.8
Component/s: Assignment, Language
Labels:
- ci
- hqteam_delta
- triaged

Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
https://github.com/snake/moodle.git
Pull Master Branch:
~~MDL-66552~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...snake:MDL-66552-master
Testing Instructions:
Hide

Purge caches

Go to Site administration > Development > Experimental > Experimental settings and enable course relative dates (enablecourserelativedates).

Create a course with relative dates mode enabled and a start date of today

Create an assignment and set the due date to 2 months in the future

As a teacher, visit the assignment

Verify you see a "Due date" value of something like "Xd Yh Zm", where X, Y and Z are integer values of days, hours and minutes respectively.
Show
Purge caches Go to Site administration > Development > Experimental > Experimental settings and enable course relative dates (enablecourserelativedates). Create a course with relative dates mode enabled and a start date of today Create an assignment and set the due date to 2 months in the future As a teacher, visit the assignment Verify you see a "Due date" value of something like "Xd Yh Zm", where X, Y and Z are integer values of days, hours and minutes respectively.

Description

As commented by mudrd8mz in ~~MDL-66147~~:

diff --git a/lang/en/moodle.php b/lang/en/moodle.php

+$string['relativedatestimediffformat'] = '%ad %hh %im';

May I suggest to improve this a little bit and

Have the string defined in the langconfig.php component.
Name it consistently with existing date time formatting strings these, for example something like strfrelativedatetimediff or so.

This would make the string easier to locate and translate or customise.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-09-12-09-30-18-439.png
25 kB
12/Sep/19 9:30 AM

Issue Links

has a non-specific relationship to

MDL-66147 As a teacher, I want to be able to create an assignment activity with a 'due date' relative to the student course start date, so that the student can complete the full course

Closed

Activity

People

Assignee:: Jake Dallimore

Reporter:: Helen Foster

Peer reviewer:: David Mudrák (@mudrd8mz)

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, David Mudrák (@mudrd8mz), Helen Foster, Jake Dallimore, Janelle Barcega

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 29/Aug/19 5:30 PM

Updated:: 13/Sep/19 11:52 AM

Resolved:: 13/Sep/19 11:52 AM

Fix Release Date:: 18/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: