Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66552

Move and rename relativedatestimediffformat lang string

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Purge caches
      2. Go to Site administration > Development > Experimental > Experimental settings and enable course relative dates (enablecourserelativedates).
      3. Create a course with relative dates mode enabled and a start date of today
      4. Create an assignment and set the due date to 2 months in the future
      5. As a teacher, visit the assignment
      6. Verify you see a "Due date" value of something like "Xd Yh Zm", where X, Y and Z are integer values of days, hours and minutes respectively.
      Show
      Purge caches Go to Site administration > Development > Experimental > Experimental settings and enable course relative dates (enablecourserelativedates). Create a course with relative dates mode enabled and a start date of today Create an assignment and set the due date to 2 months in the future As a teacher, visit the assignment Verify you see a "Due date" value of something like "Xd Yh Zm", where X, Y and Z are integer values of days, hours and minutes respectively.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66552-master

      Description

      As commented by David Mudrák (@mudrd8mz) in MDL-66147:

      diff --git a/lang/en/moodle.php b/lang/en/moodle.php
       
      +$string['relativedatestimediffformat'] = '%ad %hh %im';
      

      May I suggest to improve this a little bit and

      • Have the string defined in the langconfig.php component.
      • Name it consistently with existing date time formatting strings these, for example something like strfrelativedatetimediff or so.

      This would make the string easier to locate and translate or customise.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              David Mudrák (@mudrd8mz)
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, cameron1729, David Mudrák (@mudrd8mz), Helen Foster
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h