Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66568

Move behat theme generation to behat init

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is largely tested by behat, but you may wish to see the benefit of this change in some testing:

      1. Initialise behat: 

        php admin/tool/behat/cli/init.php

      2. Run a scenario which makes use of Javascript
        1. Confirm that once the browser window opens it does not hang around for 5-10 seconds waiting for the theme to generate
      3. Run another scenario
        1. Confirm that once the browser window opens it does not hang around for 5-10 seconds waiting for the theme to generate
      Show
      This is largely tested by behat, but you may wish to see the benefit of this change in some testing: Initialise behat: php admin/tool/behat/cli/init.php Run a scenario which makes use of Javascript Confirm that once the browser window opens it does not hang around for 5-10 seconds waiting for the theme to generate Run another scenario Confirm that once the browser window opens it does not hang around for 5-10 seconds waiting for the theme to generate
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
      MDL-66568-35-2
    • Pull 3.5 Diff URL:
    • Pull 3.8 Branch:
      MDL-66568-38-2
    • Pull 3.8 Diff URL:
    • Pull Master Branch:
      MDL-66568-master-2
    • Pull Master Diff URL:

      Description

      We should:

      1. Generate the required themes during behat init
      2. Save them somewhere
      3. Restore that part of MUC on reset of the dataroot

      This allows for much faster debugging (no waiting at the start of a run for theme to generate)

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-69072 Restart Mink session between Scenarios

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-64447 Building Theme CSS Fails

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jul/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 58 minutes
                  1d 1h 58m