[MDL-66614] $DB->get_records uses a lot of Peak RAM with Postgres (backport of MDL-66327) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.5, 3.7.1
Fix Version/s: 3.6.7, 3.7.3
Component/s: Database SQL/XMLDB
Labels:

Testing Instructions:

Hide

Copied from ~~MDL-66327~~:

CI Will test this fully

I'd recommend that any reviewer and other interested parties uses the dbmemtestcli.php script to compare the different approaches on a variety of hardware and PHP versions.

Show
Copied from MDL-66327 : CI Will test this fully I'd recommend that any reviewer and other interested parties uses the dbmemtestcli.php script to compare the different approaches on a variety of hardware and PHP versions.
Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull 3.6 Branch:
~~MDL-66614~~_36
Pull 3.6 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_36_STABLE...MDL-66614_36
Pull 3.7 Branch:
~~MDL-66614~~_37
Pull 3.7 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_37_STABLE...MDL-66614_37

Description

This fix has been in master for a while and is an important performance improvement. It would be good to get to users (and we certainly want it at the OU!) so I am opening a backport request.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

1568814064.1456.json
5 kB
18/Sep/19 9:45 PM

Issue Links

will help resolve

MDL-66327 $DB->get_records uses a lot of Peak RAM (with Postgres)

Closed

Activity

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Peer reviewer:

Sam Marshall

Integrator:

Sara Arjona (@sarjona)

Tester:

CiBoT

Participants:

CiBoT, Eloy Lafuente (stronk7), Sam Marshall, Sara Arjona (@sarjona), Tim Hunt

Component watchers:

Jake Dallimore, Jun Pataleta

Votes:

1 Vote for this issue

Watchers:

6 Start watching this issue

Dates

Created:

05/Sep/19 10:34 PM

Updated:

20/Sep/19 4:12 AM

Resolved:

20/Sep/19 4:12 AM

Fix Release Date:

11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

30m