Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66615

Review legit HTML problems reported by the CI mustache linter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8
    • Fix Version/s: None
    • Component/s: HTML and CSS
    • Labels:
    • Affected Branches:
      MOODLE_38_STABLE

      Description

      While reviewing MDL-65205 it was detected that the mustache linter (that is run by CiBoT) was reporting some warnings/errors that may be legit.

      See https://integration.moodle.org/job/Precheck%20remote%20branch/74948/artifact/work/smurf.html#mustache (as example from that issue).

      Of course some of the reported problems (specially empty tags) are false positives and can be ignored but others seem legit.

      So this issue is about to execute the mustache linter] against all the mustache templates, keep apart false positives and try to fix as many real validation issues as possible.

      Also, about to consider this task recurrently (say for every release, or yearly or whatever).

      Note that, to execute that linter you need local_ci available locally and its nodejs stuff installed with npm, to get the vnu validator at hand. Then, call to the php linter for every mustache in codebase.

      That's it. Ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: