Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66644

core_admin_renderer::required_column() expects that all plugins define the required moodle version

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Clone the tool_lifecycle plugin into your admin/tool directory:

        git clone git@github.com:learnweb/moodle-tool_lifecycle.git admin/tool/lifecycle
        

      2. Log into the site as admin
      3. Step through the upgrade until you get to the page titled "Plugins check"
        1. Confirm that the "Requires" column is empty for the subplugins (see screenshots for further detail)
      Show
      Clone the tool_lifecycle plugin into your admin/tool directory: git clone git@github.com:learnweb/moodle-tool_lifecycle.git admin/tool/lifecycle Log into the site as admin Step through the upgrade until you get to the page titled " Plugins check " Confirm that the "Requires" column is empty for the subplugins (see screenshots for further detail)
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66644-master-versionrequires

      Description

      Plugins can specify the minimum required Moodle version In their version.php (https://docs.moodle.org/dev/version.php), e.g.

      $plugin->requires = 2014051200;
      

      Declaring this requirement is recommended, yet still not required. So plugins do not need to do it. This makes particular sense for subplugins that ship with another parent plugin.

      The bug here is that when plugins do not have the requirement declared, the plugins overview page reads something like

      Moodle {$a}
      

      in their "Requires" column.

        Attachments

        1. MDL-66644.png
          MDL-66644.png
          126 kB
        2. screenshot-1.png
          screenshot-1.png
          100 kB
        3. screenshot-2.png
          screenshot-2.png
          90 kB

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Jun Pataleta
              Tester:
              Jennifer Bauzon
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 15 minutes
                  1h 15m