Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66645

Update upgrade_stale_php_files_present() before 3.8 release

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.8
    • 3.8
    • Installation
    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • Hide

      web

      1. Create/check out a 3.7.x site. For example: 

        git checkout v3.7.0

      2. Install the 3.7 site.
      3. Check out the master branch 

        git checkout master

      4. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • lib/recaptchalib.php 

          touch lib/recaptchalib.php

        • question/amd/src/qbankmanager.js 

          touch question/amd/src/qbankmanager.js

        • ...
      5. Open your Moodle instance on your browser.
      6. Log in as admin and proceed with the upgrade.
      7. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      8. Delete the touched file(s) in 2.
      9. Click "Reload".
      10. Verify that the upgrade now proceeds ok.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      web Create/check out a 3.7.x site. For example: git checkout v3.7.0 Install the 3.7 site. Check out the master branch git checkout master Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): lib/recaptchalib.php touch lib/recaptchalib.php question/amd/src/qbankmanager.js touch question/amd/src/qbankmanager.js ... Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in 2. Click " Reload ". Verify that the upgrade now proceeds ok. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

        1. image-2019-09-25-09-15-13-996.png
          247 kB
          Janelle Barcega

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Mathew May Mathew May
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 14 minutes
                1h 14m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.