Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66665

Reopened assignment shown as graded by student themselves

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Confirm unit tests pass.

      Prerequisites:

      1. Requires 2 browsers or one incognito tab.
      2. Login as admin in one and student in the other.
      3. An additional teacher user.

      Manual testing

      Case 1

      1. Login as Admin
      2. Create a Course
      3. Enroll a Student and Teacher in the Course
      4. Create an Assignment in Course
        • In 'Submission settings' set
          • Attempts reopened = Manually
          • Maximum attempts = Unlimited
          • Require students to click the submit button = Yes
      5. Login as Student.
      6. Go to Course > Assignment
        1. Add and submit a submission
      7. Login as Admin
      8. Go to Course > Assignment and click on "Grade"
      9. In the Grader panel
        1. Add a grade for the Student's submission and Allow another attempt
      10. Login as Student.
      11. Go to Course > Assignment
      12. Verify there is no grader information shown under Feedback, Graded by
      13. Modify the submission by either clicking the 'Add new attempt' or 'Add to existing attempt' button
      14. After submitting the modification, before clicking the submit button, CONFIRM the graded by still appears as the grader.
      15. Submit the assignment
      16. As an admin, go to the assignment and view all submissions
      17. Login as Teacher
      18. Go to the course and the assignment and view all submissions
      19. Update the grade for the assignment 
      20. As a student, in the assignment confirm that the graded by is now the Teacher.
      21. Login as an admin and Revert to draft the recently submitted assignment.
      22. As a student, in the assignment confirm that the graded by is still the grader and not the student.

      Case2: Group assignments

      1. Login as Admin
      2. Create a Course
      3. Enroll a few Students and a Teacher in the Course
      4. Create a couple of groups with the students enrolled
        1. Students 1 and 2 in groupA
        2. The rest in other groups
      5. Create an Assignment in Course
        • In 'Submission settings' set
          • Attempts reopened = Manually
          • Maximum attempts = Unlimited
          • Require students to click the submit button = Yes
        • Group submission settings
          • Students submit in groups - Yes
      6. Login as Student1.
      7. Go to Course > Assignment
        1. Add and submit a submission
      8. Login as Admin
      9. Go to Course > Assignment and click on "Grade"
      10. In the Grader panel
        1. Add a grade for the Student's submission and Allow another attempt
      11. Login as Student1.
      12. Go to Course > Assignment
      13. Verify there is no grader information shown under Feedback, Graded by
      14. Login as Student2
      15. Repeat #12-#13
      16. Modify the submission by either clicking the 'Add new attempt' or 'Add to existing attempt' button
      17. After submitting the modification, before clicking the submit button, CONFIRM the graded by still appears as the grader.
      18. Submit the assignment
      19. As an admin, go to the assignment and view all submissions and add a grade for the assignment
      20. Login as Teacher
      21. Go to the course and the assignment and view all submissions
      22. Update the grade for the same submission  
      23. As student1, in the assignment confirm that the graded by is now the Teacher.
      24. Login as the admin and Revert to draft the recently submitted assignment.
      25. As a student1, in the assignment confirm that the graded by is still the grader and not the student.
      26. As student 2, in the assignment confirm that the graded by is still the grader and not the student.

       

      Repeat: The manual test from MDL-60685

      Show
      Confirm unit tests pass. Prerequisites: Requires 2 browsers or one incognito tab. Login as admin in one and student in the other. An additional teacher user. Manual testing Case 1 Login as Admin Create a Course Enroll a Student and Teacher in the Course Create an Assignment in Course In 'Submission settings' set Attempts reopened = Manually Maximum attempts = Unlimited Require students to click the submit button = Yes Login as Student. Go to Course > Assignment Add and submit a submission Login as Admin Go to Course > Assignment and click on "Grade" In the Grader panel Add a grade for the Student's submission and Allow another attempt Login as Student. Go to Course > Assignment Verify there is no grader information shown under Feedback, Graded by Modify the submission by either clicking the 'Add new attempt' or 'Add to existing attempt' button After submitting the modification,  before clicking the submit button, CONFIRM the graded by still appears as the grader. Submit the assignment As an admin, go to the assignment and view all submissions Login as Teacher Go to the course and the assignment and view all submissions Update the grade for the assignment  As a student, in the assignment  confirm  that the graded by is now the Teacher. Login as an admin and Revert to draft the recently submitted assignment. As a student, in the assignment  confirm  that the graded by is still the grader and not the student. Case2: Group assignments Login as Admin Create a Course Enroll a few Students and a Teacher in the Course Create a couple of groups with the students enrolled Students 1 and 2 in groupA The rest in other groups Create an Assignment in Course In 'Submission settings' set Attempts reopened = Manually Maximum attempts = Unlimited Require students to click the submit button = Yes Group submission settings Students submit in groups - Yes Login as Student1. Go to Course > Assignment Add and submit a submission Login as Admin Go to Course > Assignment and click on "Grade" In the Grader panel Add a grade for the Student's submission and Allow another attempt Login as Student1. Go to Course > Assignment Verify there is   no grader information shown under Feedback, Graded by Login as Student2 Repeat #12-#13 Modify the submission by either clicking the 'Add new attempt' or 'Add to existing attempt' button After submitting the modification,  before clicking the submit button, CONFIRM the graded by still appears as the grader. Submit the assignment As an admin, go to the assignment and view all submissions and add a grade for the assignment Login as Teacher Go to the course and the assignment and view all submissions Update the grade for the same submission    As student1, in the assignment  confirm  that the graded by is now the Teacher. Login as the admin and Revert to draft the recently submitted assignment. As a student1, in the assignment  confirm  that the graded by is still the grader and not the student. As student 2, in the assignment  confirm  that the graded by is still the grader and not the student.   Repeat: The manual test from MDL-60685
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MDL-66665-39-POC2
    • Pull Master Branch:
      MDL-66665-master-POC2
    • Story Points:
      3
    • Sprint:
      Activity Sprint 2, 4.0 holding pattern 3, 4.0 holding pattern 4

      Description

      Graded by shows the student who has been graded, when an assignment has been re-opened
      To replicate:

      1. Create an assignment
      2. Grade a student and Allow another attempt
      3. Login as the student
      4. Verify that the students name and picture show under Feedback, Graded by

        Attachments

        1. grading problem.png
          grading problem.png
          154 kB
        2. MDL-66665_Case1.jpg
          MDL-66665_Case1.jpg
          32 kB
        3. MDL-66665_Case2.jpg
          MDL-66665_Case2.jpg
          44 kB

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              cdipe Peter Diedrichs
              Peer reviewer:
              Mathew May Mathew May
              Integrator:
              Adrian Greeve Adrian Greeve
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              7 Vote for this issue
              Watchers:
              15 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 1 hour, 58 minutes
                  2d 1h 58m