Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66679

Submit button remains disabled after file download

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a new assignment, setting it to allow 'online text' submissions.
      2. Log in as a test student account, go to the assignment, click Add submission, type some text and click Save changes.
      3. Log back in as admin and go to the assignment.
      4. Click View all submissions.
      5. Select the student check box.
      6. From the 'With selected' select (below the table), select 'Download selected submissions'.
      7. Click 'Go' and then OK to download the file.
        • EXPECTED: The 'Go' button should be briefly disabled (it changes colour slightly) but once the file finishes downloading, it should be re-enabled, and you can click it again to repeat the download if you like.
      Show
      Create a new assignment, setting it to allow 'online text' submissions. Log in as a test student account, go to the assignment, click Add submission, type some text and click Save changes. Log back in as admin and go to the assignment. Click View all submissions. Select the student check box. From the 'With selected' select (below the table), select 'Download selected submissions'. Click 'Go' and then OK to download the file. EXPECTED: The 'Go' button should be briefly disabled (it changes colour slightly) but once the file finishes downloading, it should be re-enabled, and you can click it again to repeat the download if you like.
    • Affected Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66679-master

      Description

      This is a regression caused by MDL-38555.

      Easy way to replicate the problem in 3.8:
      1. Create an assignment and submit something as a student (text is fine)
      2. As the teacher, view all submissions
      3. Select the student check box
      4. From the 'With selected' select (below the table), select 'Download selected submissions'.
      5. Click 'Go' and download the file
      6. Notice the 'Go' button is disabled.

      In the download case, there is an unload event (for me, on firefox at least), meaning the form field gets disabled.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                quen Sam Marshall
                Reporter:
                jaked Jake Dallimore
                Peer reviewer:
                Jake Dallimore
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Barbara Ramiro, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: