Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66679

Submit button remains disabled after file download

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: The last part of this test script requires the ability to run a patch against the code being tested.

      1. Create a new assignment, setting it to allow 'online text' submissions.
      2. Log in as a test student account, go to the assignment, click Add submission, type some text and click Save changes.
      3. Log back in as admin and go to the assignment.
      4. Click View all submissions.
      5. Select the student check box.
      6. From the 'With selected' select (below the table), select 'Download selected submissions'.
      7. Click 'Go' and then OK to download the file.
        • EXPECTED: The 'Go' button should be briefly disabled (it changes colour slightly) but once the file finishes downloading, it should be re-enabled, and you can click it again to repeat the download if you like.
      8. Click the Grade button.
      9. Type a grade, like 42, and save changes.
      10. Go back to the course page and click Grades.
      11. Go to the Export tab.
      12. Click to each tab in turn and click 'Download'.
        • EXPECTED: The download button should be briefly disabled, but once the download gets under way, it should be enabled again.
      13. Go to a forum (or create a new one) that has at least one discussion topic.
      14. From the cog in the forum main page, choose 'Export'.
      15. At the bottom of the form, click the 'Export' button.
        • EXPECTED: The export button should be briefly disabled, but once the download starts, it should be enabled again.
      16. Apply the attached mdl-66679.patch which is supposed to turn off the double-click protection on the course settings form.
      17. Go to the course page.
      18. Click the cog icon and choose 'Edit settings'.
      19. Scroll to bottom of page and choose 'Save changes'. Watch the button carefully.
        • EXPECTED: The 'Save changes' button does not appear disabled at any point.
      Show
      Note: The last part of this test script requires the ability to run a patch against the code being tested. Create a new assignment, setting it to allow 'online text' submissions. Log in as a test student account, go to the assignment, click Add submission, type some text and click Save changes. Log back in as admin and go to the assignment. Click View all submissions. Select the student check box. From the 'With selected' select (below the table), select 'Download selected submissions'. Click 'Go' and then OK to download the file. EXPECTED: The 'Go' button should be briefly disabled (it changes colour slightly) but once the file finishes downloading, it should be re-enabled, and you can click it again to repeat the download if you like. Click the Grade button. Type a grade, like 42, and save changes. Go back to the course page and click Grades. Go to the Export tab. Click to each tab in turn and click 'Download'. EXPECTED: The download button should be briefly disabled, but once the download gets under way, it should be enabled again. Go to a forum (or create a new one) that has at least one discussion topic. From the cog in the forum main page, choose 'Export'. At the bottom of the form, click the 'Export' button. EXPECTED: The export button should be briefly disabled, but once the download starts, it should be enabled again. Apply the attached mdl-66679.patch which is supposed to turn off the double-click protection on the course settings form. Go to the course page. Click the cog icon and choose 'Edit settings'. Scroll to bottom of page and choose 'Save changes'. Watch the button carefully. EXPECTED: The 'Save changes' button does not appear disabled at any point.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66679-master

      Description

      This is a regression caused by MDL-38555.

      Easy way to replicate the problem in 3.8:
      1. Create an assignment and submit something as a student (text is fine)
      2. As the teacher, view all submissions
      3. Select the student check box
      4. From the 'With selected' select (below the table), select 'Download selected submissions'.
      5. Click 'Go' and download the file
      6. Notice the 'Go' button is disabled.

      In the download case, there is an unload event (for me, on firefox at least), meaning the form field gets disabled.

        Attachments

        1. mdl66679.patch
          0.5 kB
          Sam Marshall
        2. mdl66679.php
          2 kB
          Sam Marshall
        3. Screenshot_1.png
          245 kB
          Janelle Barcega
        4. Screenshot_2.png
          50 kB
          Janelle Barcega

          Issue Links

            Activity

              People

              Assignee:
              quen Sam Marshall
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Adrian Greeve
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 30 minutes
                  3h 30m