[MDL-66723] Unused variables in classic theme's columns template - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Reopened
Priority: Minor
Resolution: Unresolved
Affects Version/s: 3.7.2
Fix Version/s: None
Component/s: Themes
Labels:
- triaged

Affected Branches:
MOODLE_37_STABLE
Pull from Repository:
git://git.cameron1729.xyz/moodle.git
Pull Master Branch:
MDL-66723-master
Pull Master Diff URL:
http://git.cameron1729.xyz/?p=moodle.git;a=commitdiff;h=MDL-66723-master
Testing Instructions:
1. grep theme/classic for occurrences of "regionmainsettingsmenu" and ensure there are no results

Description

In classic, the mustache template columns.mustache checks for hasregionmainsettingsmenu but it is not passed in from columns.php

Since these variables are unused (as settings cogs are not present in classic), they should be removed from the template.

Attachments

Activity

People

Assignee:: cameron1729

Reporter:: cameron1729

Peer reviewer:: Mathew May

Integrator:: Andrew Lyons

Participants:: Andrew Lyons, Bas Brands, cameron1729, CiBoT, Mathew May

Component watchers:: Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 19/Sep/19 10:51 AM

Updated:: 02/Mar/23 10:06 AM

Time Tracking

Estimated:

0m

Remaining:

0m

Logged:

1h 15m