Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66749

Messaging: personal space message now stands out from background color.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      • Login as Admin
      • Open message drawer
      • Open personal space
      • Verify the message "Personal space..." does not have its own container with a different shade of grey in the background compared to the container that holds the messages (see attached screenshot)
      • Add a new user
      • Open your message drawer and search for the user
      • Add the user as a contact
      • Verify the message "Contact request sent.." does not have its own container with a different shade of gray in the background compared to the container that holds the messages (see attached screenshot)
      Show
      Login as Admin Open message drawer Open personal space Verify the message "Personal space..." does not have its own container with a different shade of grey in the background compared to the container that holds the messages (see attached screenshot) Add a new user Open your message drawer and search for the user Add the user as a contact Verify the message "Contact request sent.." does not have its own container with a different shade of gray in the background compared to the container that holds the messages (see attached screenshot)
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66749-master

      Description

      This is a regression caused by MDL-65205.

      1. Open the message drawer on master.
      2. View your personal space
      3. Notice the message at the top is inside a light grey box now. On 3.7 the container is the same colour as the background.

      This is because the background was changed, but the styling on this self-conversation-message-container was not updated.

      Is this as simple as removing the bg-light class?

        Attachments

        1. after.pdf
          95 kB
        2. before.pdf
          102 kB
        3. image-2019-10-08-10-27-48-002.png
          image-2019-10-08-10-27-48-002.png
          29 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 35 minutes
                  35m