Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66750

Formslib templates: size attribute can apply to any select, not just multiple, and should apply to selectgroup as well as select

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.2, 3.8
    • Fix Version/s: 3.7.3
    • Component/s: Forms Library, Themes
    • Labels:
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Install https://moodle.org/plugins/tool_editrolesbycap
      2. Go to Admin -> Users -> Permissions -> Edit roles by capability.
      3. Verify that it looks like this:
      4. Add test.php to your moodle web root and view it as YOUR_LOCAL_SITE/test.php
      5. Verify all selects are rendered with a size of 5.
      Show
      Install https://moodle.org/plugins/tool_editrolesbycap Go to Admin -> Users -> Permissions -> Edit roles by capability. Verify that it looks like this: Add test.php to your moodle web root and view it as YOUR_LOCAL_SITE/test.php Verify all selects are rendered with a size of 5.

      Description

      It turns out that Boost, and now Classic themes break tool_editrolesbycap (https://moodle.org/plugins/tool_editrolesbycap.

      The select-related templates handle the size attribute wronly. There are usability reasons why sometimes you want size set without multiple (e.g. Moodle groups UI).

        Attachments

        1. image-2019-10-08-10-23-44-858.png
          image-2019-10-08-10-23-44-858.png
          107 kB
        2. screenshot-1.png
          screenshot-1.png
          22 kB
        3. test.php
          2 kB

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Jake Dallimore Jake Dallimore
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Janelle Barcega Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Huong Nguyen, Bas Brands, Mathew May
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 5 minutes
                1h 5m