Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66767

Update groups filter to be a content filter rather than user filter

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Log in as admin.
      2. Create a course, 'course1' with the following users:
        teacher1
        teacher2 (non-editing teacher)
        student1
        student2
      3. Create 3 groups in the course, group1, group2 and group3.
      4. Assign the following users to the groups:
        Group Users
        group1 teacher1, student1
        group2 teacher2
        group3 teacher2, student2
      5. Create a grouping, 'groupingA', which contains group2 and group3.
      6. Navigate to course1 and add a forum activity, forum1. Under 'Common module settings', set 'Group mode' to 'Visible groups'.
      7. Add a second forum activity, forum2, which has no group mode set.
      8. Click 'Save and display'.
      9. Log in as the following users, and make the relevant number of discussion/reply posts within forum1, under the relevant groups:
        User Group Discussions Replies
        teacher1 group1 1 2
        teacher1 all participants 1 0
        teacher2 group2 2 1
        teacher2 group3 1 1
        student1 group1 0 2
      10. Login as the following users, and make the relevant number of discussion/reply posts within forum2:
        User Discussions Replies
        teacher1 1 1
        student1 1 1

      Testing - no groups

      1. Log in as teacher1.
      2. Navigate to forum2, open the actions menu and click "Summary report".
      3. CONFIRM there is no groups filter button visible, and the following report information is displayed:
        First/surname Discussions Replies
        teacher1 1 1
        teacher2 0 0
        student1 1 1
        student2 0 0

      Testing - groups modes and capability

      1. Log in as teacher1.
      2. Navigate to forum1, open the actions menu and click "Summary report".
      3. CONFIRM the groups filter button is visible, and the following report information is displayed:
        First/surname Discussions Replies
        teacher1 2 2
        teacher2 3 2
        student1 0 2
        student2 0 0
      4. Press the "Groups" button to open the groups filter.
      5. CONFIRM the following groups are available:
        group1
        group2
        group3
        no groups
      6. Select "group 1" and "No groups" and click 'Save'.
      7. CONFIRM the following report information is displayed:
        First/surname Discussions Replies
        teacher1 2 2
        teacher2 0 0
        student1 0 2
        student2 0 0
      8. Re-open groups filter and uncheck 'no groups', so only 'group1' is checked. Click "Save".
      9. CONFIRM you only see the following users, with the following details:
        First/surname Discussions Replies
        teacher1 1 2
        student1 0 2
      10. Navigate to the forum1 edit settings page, and set forum grouping to GroupA.
      11. Log in as teacher 2, and open the forum summary report for forum1.
      12. Open the groups filter and CONFIRM only the following options are available:
        group2
        group3
        no groups
      13. Log back in as teacher1.
      14. Navigate back to the forum1 edit settings page, and under 'Common module settings', remove the grouping from the forum.
      15. Also set the group mode to "separate groups", then save.
      16. Log back in as teacher2.
      17. Return to the forum1 summary report.
      18. CONFIRM you only see the following users, with the following details:
        First/surname Discussions Replies
        teacher2 3 2
        student2 0 0
      19. Open the groups filter and CONFIRM you now only see group2 and group3.
      20. Select Group 3 and click 'Save'.
      21. CONFIRM you only see the following users, with the following details:
        First/surname Discussions Replies
        teacher2 1 1
        student2 0 0
      22. Log in as teacher1 and visit the forum1 summary report.
      23. CONFIRM you now see the following report details:
        First/surname Discussions Replies
        teacher1 2 2
        teacher2 3 2
        student1 0 2
        student2 0 0
      24. Open the groups filter and CONFIRM you now see the following groups:
        group1
        group2
        group3
        no groups
      Show
      Setup Log in as admin. Create a course, 'course1' with the following users: teacher1 teacher2 (non-editing teacher) student1 student2 Create 3 groups in the course, group1, group2 and group3. Assign the following users to the groups: Group Users group1 teacher1, student1 group2 teacher2 group3 teacher2, student2 Create a grouping, 'groupingA', which contains group2 and group3. Navigate to course1 and add a forum activity, forum1. Under 'Common module settings', set 'Group mode' to 'Visible groups'. Add a second forum activity, forum2, which has no group mode set. Click 'Save and display'. Log in as the following users, and make the relevant number of discussion/reply posts within forum1, under the relevant groups: User Group Discussions Replies teacher1 group1 1 2 teacher1 all participants 1 0 teacher2 group2 2 1 teacher2 group3 1 1 student1 group1 0 2 Login as the following users, and make the relevant number of discussion/reply posts within forum2: User Discussions Replies teacher1 1 1 student1 1 1 Testing - no groups Log in as teacher1. Navigate to forum2, open the actions menu and click "Summary report". CONFIRM there is no groups filter button visible, and the following report information is displayed: First/surname Discussions Replies teacher1 1 1 teacher2 0 0 student1 1 1 student2 0 0 Testing - groups modes and capability Log in as teacher1. Navigate to forum1, open the actions menu and click "Summary report". CONFIRM the groups filter button is visible, and the following report information is displayed: First/surname Discussions Replies teacher1 2 2 teacher2 3 2 student1 0 2 student2 0 0 Press the "Groups" button to open the groups filter. CONFIRM the following groups are available: group1 group2 group3 no groups Select "group 1" and "No groups" and click 'Save'. CONFIRM the following report information is displayed: First/surname Discussions Replies teacher1 2 2 teacher2 0 0 student1 0 2 student2 0 0 Re-open groups filter and uncheck 'no groups', so only 'group1' is checked. Click "Save". CONFIRM you only see the following users, with the following details: First/surname Discussions Replies teacher1 1 2 student1 0 2 Navigate to the forum1 edit settings page, and set forum grouping to GroupA. Log in as teacher 2, and open the forum summary report for forum1. Open the groups filter and CONFIRM only the following options are available: group2 group3 no groups Log back in as teacher1. Navigate back to the forum1 edit settings page, and under 'Common module settings', remove the grouping from the forum. Also set the group mode to "separate groups", then save. Log back in as teacher2. Return to the forum1 summary report. CONFIRM you only see the following users, with the following details: First/surname Discussions Replies teacher2 3 2 student2 0 0 Open the groups filter and CONFIRM you now only see group2 and group3. Select Group 3 and click 'Save'. CONFIRM you only see the following users, with the following details: First/surname Discussions Replies teacher2 1 1 student2 0 0 Log in as teacher1 and visit the forum1 summary report. CONFIRM you now see the following report details: First/surname Discussions Replies teacher1 2 2 teacher2 3 2 student1 0 2 student2 0 0 Open the groups filter and CONFIRM you now see the following groups: group1 group2 group3 no groups
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
    • Sprint:
      Internationals - 3.8 Sprint 8

      Description

      The groups filter currently filters the report by users within a group, but should be filtering the content by group, ie filtering the data to only include data from posts within the specified groups.

      Filtering users by group can potentially be moved into "more filters" when it exists, as an additional part of the user filtering.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 2 hours, 16 minutes
                  3d 2h 16m