Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66770

Make experimental nested discussion view a user preference plus other visual improvements

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Forum
    • Testing Instructions:
      Hide

      Setup

      1. Create a course and add a forum module
      2. Enrol some users in the course
      3. Create a few discussions with a few different users and add some replies to those discussions

      Subscribing to discussions

      1. One bigger changes was to move the subscription toggle out of the overflow menu and into it's own column on the discussion list page
      2. CONFIRM that clicking the subscription toggle subscribes/unsubscribes the user, if you click the toggle and then reload the page it should be in the same state (confirms the value is saved)

      Placeholder group image

      1. Another change was to add a placeholder image for groups that don't have an image when viewing the discussion (this brings the behaviour inline with what happens when viewing the discussion list)
      2. Set the forum to groups mode (in the settings under "common module settings" set the group mode to separate groups or visible groups)
      3. Create a group in the course but don't add a picture for it
      4. Create a second group in the course and add a picture for this one
      5. Add at least one user to each group
      6. Log in as a user in the group without the picture
      7. Create a discussion in that group
      8. CONFIRM that you see the placeholder image next to the group name in the list of discussions
      9. View the discussion
      10. CONFIRM that you see the same placeholder image next to the posts for that user inside the discussions
      11. Log in as a user in the group with the picture
      12. Create a discussion in that group
      13. CONFIRM that you see the group image next to the group name in the list of discussions
      14. View the discussion
      15. CONFIRM that you see the same group image next to the posts for that user inside the discussions

      Old nested view

      1. Log in as a user and view a discussion
      2. Click the displays select box and confirm that you don't seen an option for "Display replies in experimental nested form", you should see:
        • Display replies in flat, with oldest first
        • Display replies in flat, with newest first
        • Display replies in threaded form
        • Display replies in nested form
      3. CONFIRM that you can change between each of the views
      4. Set it back to "Display replies in nested form"

      New experimental nested view

      1. Still logged in as the same user from the "Old nested view" test
      2. View the user's forum preferences
        • user menu (top right) > preferences > forum preferences
      3. Set "Use experimental nested discussion view" from "No" to "Yes"
      4. View a discussion
      5. CONFIRM that the view has changed to "Display replies in experimental nested form"
      6. CONFIRM that the list of options in the displays select box is:
        • Display replies in flat, with oldest form
        • Display replies in flat, with newest form
        • Display replies in threaded form
        • Display replies in experimental nested form
      7. CONFIRM that you can change between views
      Show
      Setup Create a course and add a forum module Enrol some users in the course Create a few discussions with a few different users and add some replies to those discussions Subscribing to discussions One bigger changes was to move the subscription toggle out of the overflow menu and into it's own column on the discussion list page CONFIRM that clicking the subscription toggle subscribes/unsubscribes the user, if you click the toggle and then reload the page it should be in the same state (confirms the value is saved) Placeholder group image Another change was to add a placeholder image for groups that don't have an image when viewing the discussion (this brings the behaviour inline with what happens when viewing the discussion list) Set the forum to groups mode (in the settings under "common module settings" set the group mode to separate groups or visible groups) Create a group in the course but don't add a picture for it Create a second group in the course and add a picture for this one Add at least one user to each group Log in as a user in the group without the picture Create a discussion in that group CONFIRM that you see the placeholder image next to the group name in the list of discussions View the discussion CONFIRM that you see the same placeholder image next to the posts for that user inside the discussions Log in as a user in the group with the picture Create a discussion in that group CONFIRM that you see the group image next to the group name in the list of discussions View the discussion CONFIRM that you see the same group image next to the posts for that user inside the discussions Old nested view Log in as a user and view a discussion Click the displays select box and confirm that you don't seen an option for "Display replies in experimental nested form", you should see: Display replies in flat, with oldest first Display replies in flat, with newest first Display replies in threaded form Display replies in nested form CONFIRM that you can change between each of the views Set it back to "Display replies in nested form" New experimental nested view Still logged in as the same user from the "Old nested view" test View the user's forum preferences user menu (top right) > preferences > forum preferences Set "Use experimental nested discussion view" from "No" to "Yes" View a discussion CONFIRM that the view has changed to "Display replies in experimental nested form" CONFIRM that the list of options in the displays select box is: Display replies in flat, with oldest form Display replies in flat, with newest form Display replies in threaded form Display replies in experimental nested form CONFIRM that you can change between views
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66770-master-2

      Description

      Jake suggested in MDL-64821 that it might be worth adding default placeholder images for groups that don't have images added (otherwise they won't be displayed at all).

      There is also some feedback to come from the UX team to tweak some of the spacing, sizing, fonts etc.

      Additional requirements raised in MDL-66952:

      1. Make the new Nested UI design a user preference, not a forum display dropdown option. So the user by default sees the existing Nested view, unless they in their preferences select to see the 'Experimental Nested View' (new design)
      2. Experimental nested view in RTL does not show the groups icon; to be added.
      3. The new UI design should only be applied for the nested view (as per 1 above). All other forum pages (discussion list page, new grading page, new reporting/export page) are to remain as closely as possible to the existing Boost theme.
      4. The page header with course title, bread crumb and search option is to remain as per standard boost
      5. Forum name to be displayed below that as per standard boost

        Attachments

        1. after_4.png
          after_4.png
          1.25 MB
        2. after_5.png
          after_5.png
          1.26 MB
        3. before_4.png
          before_4.png
          1.25 MB
        4. before_5.png
          before_5.png
          1.25 MB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 3 hours, 7 minutes
                  4d 3h 7m