Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66790

Regression in quiz reports caused by MDL-65938 select all changes

    XMLWordPrintable

Details

    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-66790-master
    • Hide

      Note: Test on supported browsers on Boost and Classic.

      Setup
      1. Create a quiz
      2. Enrol at least 2 students in the course
      3. As the students, log in and attempt the quiz.
      Overview report
      1. Log in as a teacher.
      2. Go to the quiz.
      3. Open the cog and under "Results", click "Grades"
      4. Tick the master checkbox at the column header.
      5. Confirm that it ticks all of the other attempts.
      6. Confirm that the page does not refresh and you don't see any error.
      Responses report
      1. Go back to the quiz's view page.
      2. Open the cog and under "Results", click "Responses"
      3. Tick the master checkbox at the column header.
      4. Confirm that it ticks all of the other attempts.
      5. Confirm that the page does not refresh and you don't see any error.
      Show
      Note: Test on supported browsers on Boost and Classic. Setup Create a quiz Enrol at least 2 students in the course As the students, log in and attempt the quiz. Overview report Log in as a teacher. Go to the quiz. Open the cog and under " Results ", click " Grades " Tick the master checkbox at the column header. Confirm that it ticks all of the other attempts. Confirm that the page does not refresh and you don't see any error. Responses report Go back to the quiz's view page. Open the cog and under " Results ", click " Responses " Tick the master checkbox at the column header. Confirm that it ticks all of the other attempts. Confirm that the page does not refresh and you don't see any error.

    Description

      This is a regression caused by MDL-65938. Steps to reproduce:

      1. Go to https://qa.moodledemo.net/mod/quiz/report.php?id=30&mode=overview
      2. Log in as teacher.
      3. Click the 'Select all' checkbox.

      Expected result: All checkboxes in that column get checked.

      Acutal result: Page reloads with error
      Error reading from database

      More information about this error
      Debug info: Unknown column 'checkbox' in 'order clause'
      SELECT
      DISTINCT CONCAT(u.id, '#', COALESCE(quiza.attempt, 0)) AS uniqueid, ...

      Attachments

        Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-65938 Use the checkbox-toggleall component for the quiz activity

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jpataleta Jun Pataleta
              timhunt Tim Hunt
              Tim Hunt Tim Hunt
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Gladys Basiana Gladys Basiana
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m