[MDL-66834] Trigger question_updated/question_created event only after all data saved to DB... - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7, 3.7.4, 3.8.1
Fix Version/s: 3.7.5, 3.8.2
Component/s: Questions
Labels:
- ci
- triaged

Testing Instructions:

Hide

The functionality is already tested by https://github.com/moodle/moodle/blob/master/question/tests/events_test.php.

Show
The functionality is already tested by https://github.com/moodle/moodle/blob/master/question/tests/events_test.php .
Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/kepeter/moodle.git
Pull Master Branch:
~~MDL-66834~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...kepeter:MDL-66834-master

Description

In questiontypebase.php::question_type::save_question method, the triggering of those events (depending on new or updated question) is before all the DB is updated... Like type specific options and question version...

IMHO it was better to trigger the events after all the data upd-to-date...

Attachments

Activity

People

Assignee:: Peter Eliyahu Kornfeld

Reporter:: Peter Eliyahu Kornfeld

Peer reviewer:: Tim Hunt

Integrator:: Sara Arjona (@sarjona)

Tester:: CiBoT

Participants:: CiBoT, Peter Eliyahu Kornfeld, Sara Arjona (@sarjona), Tim Hunt

Component watchers:: Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 03/Oct/19 5:59 PM

Updated:: 14/Feb/20 7:51 PM

Resolved:: 14/Feb/20 7:51 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

15m