Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66866

Anonymous feedback notifications are sent to teachers of all groups

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.8, 3.6.6, 3.7.2
    • Fix Version/s: None
    • Component/s: Email, Feedback
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE

      Description

      Problem description:

      When using feedback activity in anonymous mode, notification email about new feedback submission is sent to all users with mod/feedback:receivemail capability, regardless of their group assignment or whether they have the moodle/site:accessallgroups capability granted.

      Expected behaviour:

      Notification about new feedback submission is sent only to users which:

      1. Have the role with mod/feedback:receivemail capability granted
      2. AND either:
        1. There are no groups in the course to which the feedback activity belongs
        2. OR they belong to the same group as the feedback submitter
        3. OR their role has the moodle/site:accessallgroups capability granted, and therefore they do not need to belong to the same group.

      Real behaviour:

      Regardless of the moodle/site:accessallgroups capability setting and group membership, all users with capability to receive feedback notifications do receive email when feedback from user in any group is received.

      This happens only for anonymous feedbacks — non-anonymous feedbacks respect the group membership and send emails only to the same-group notification receivers, or the ones that can see all groups.

      Why this is a bug:

      Firstly, the expected behaviour can be successfully observed in feedbacks that are not anonymous. So only the anonymous ones do not respect group organisation of the course.

      Secondly, if this was meant to be a security measure (i.e., because the feedback mode is anonymous, notification receivers shouldn't know to which group the feedback sender belongs), it does not make sense, because feedbacks are still properly sorted into groups when logging into Moodle site.

      Thirdly, these emails are confusing to users receiving them. After clicking on the links supplied in the email, such user cannot see the submitted feedback, as it belongs to another group which he cannot see – in some cases leading to a situation, where empty list of feedbacks is shown to him.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            furlosk Robert Toth
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: