Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66883

Use Bootstrap switch element instead of 'switch' class

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.9
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test the message drawer switches

      1. Login as Admin
      2. Click the message drawer icon
      3. Click the cog icon in the message drawer
      4. Verify you see a toggle switch before the "Email" notification preference
      5. Verify you see a toggle switch before the "Use enter to send" notification preference
      6. Toggle both preferences on
      7. Reload the page
      8. Navigate back to the message drawer preferences
      9. Verify the toggles are still on
      10. Toggle both preference off
      11. Navigate back to the message drawer preferences
      12. Verify the toggles are still off

      Test the forum switches

      1. Login as admin
      2. Create a new course C1
      3. Create a new forum F1 in course C1
      4. Create a new discussion topic
      5. Verify you see a subscribe switch similar to this:

       

      Show
      Test the message drawer switches Login as Admin Click the message drawer icon Click the cog icon in the message drawer Verify you see a toggle switch before the "Email" notification preference Verify you see a toggle switch before the "Use enter to send" notification preference Toggle both preferences on Reload the page Navigate back to the message drawer preferences Verify the toggles are still on Toggle both preference off Navigate back to the message drawer preferences Verify the toggles are still off Test the forum switches Login as admin Create a new course C1 Create a new forum F1 in course C1 Create a new discussion topic Verify you see a subscribe switch similar to this:  
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66883-master

      Description

      Bootstrap has its own switch element now, so we should use it instead of faking it by 'switch' class.

      'switch' class is used in message drawer and modern forum templates.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              amaia Amaia Anabitarte
              Peer reviewer:
              Ferran Recio
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 10 minutes
                  1d 1h 10m