Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66893

Improve the Forum grader UI

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      NOTE

      The posts will render in the standard nested post view (which doesn't look like the attached mock up) unless you enable the experimental view (see the specific test for that).

      Repeat testing from MDL-66074 (with some small changes)

      • Log in as an Admin
      • Restore the course from the attached backup (backup-moodle2-course-5-mdl-66074-20191029-0201.mbz)
      • Navigate to the course Forum grading QA
      • Navigate to 'Points Forum'
      • Confirm that a 'Grade users' button does not appear
      • Edit the Forum 'Points Forum'
      • Under the 'Whole forum grading' heading set the following
        • Grade:
          • Type: Point
          • Maximum grade: 100
        • Grading method: Simple direct grading
        • Grade to pass: 75
      • Log in as 'Ian Duncan' (username: T1, password: test)
        Points grading
      • Navigate back to the 'Points Forum'
      • Confirm that the 'Grade users' button now appears
      • Click the 'Grade users' button
      • Confirm a fullscreen Modal appears
      • Confirm the grading interface renders
      • Confirm that 'Points Forum > Grading' appears in the top left
      • Confirm that the posts for user "Abed Nadir" render
      • Enter under "Grade" 150"
      • Confirm that you get a toast informing you that the grade save failed
      • Enter under "Grade" set the field to empty
      • Confirm that there was no error
      • Enter under "Grade" 70
      • In a seperate browser
        • Navigate to Forum grading QA
        • Navigate to the grader report
        • Confirm the user Abed Nadir has a grade of 70 for 'Points Forum'
      • Back in the original browser
      • Under the "Grading" pane find the User selector
      • Next to the User "Abed Nadir" select the ">" button
      • Confirm a loading spinner appears
      • Confirm the loading spinner disappears
      • Confirm "Abed Nadir" is no longer shown in the selector
      • Confirm the posts by "Abed Nadir" are no longer shown
      • Confirm that a toast stating "Grade saved for Abed Nadir"
      • Confirm "Shirley Bennett" is shown in the selector
      • Confirm that the posts for user "Shirley Bennett" render
      • Confirm that one discussion heading is "Daylight savings time"
      • Confirm that under the discussion "Daylight savings time" you see the post "Sorry I'm late. The sidewalk is more comfortable than it looks."
      • Confirm that the post by "Shirley Bennett" shows under the post by Ian Duncan ""Sorry I'm late. The sidewalk is more comfortable than it looks."
      • Click on the button 'View conversation' under the post 'Oh, that's not nice!'
      • Confirm that a modal appears
      • Confirm that the post 'Oh, that's not nice!' gets automatically scrolled to
      • Scroll to the bottom of the modal
      • Click the 'Cancel' button
      • Add a grade of 55 for user "Shirley Bennett"
      • Click the "Save" button in the top right of the Grading interface
      • Back in the seperate browser
        • Navigate to Forum grading QA
        • Navigate to the grader report
        • Confirm the user Shirley Bennett has a grade of 55 for 'Points Forum'

      Marking Guide grading

      • Navigate to the course Forum grading QA
      • Navigate to the 'Marking Guide Forum'
      • Edit the Forum 'Marking Guide Forum'
      • Under the 'Whole forum grading' heading set the following
        • Grade:
          • Type: Point
          • Maximum grade: 100
        • Grading method: Marking guide
        • Grade to pass: 75
      • Click 'Save changes'
      • Navigate back to the 'Marking Guide Forum'
      • Click the 'Grade users' button
      • Confirm that the posts for user "Abed Nadir" render
      • Confirm that under 'Grade' confirm you see
        • Criterion 1
          • 'Out of 60'
          • 'Additional comments'
        • Criterion 2
          • 'Out of 30'
          • 'Additional comments'
        • Criterion 3
          • 'Out of 10'
          • 'Additional comments'
      • Under 'Criterion 1' enter a grade of 45
      • Under 'Criterion 1' enter a comment of "Awesome motivation"
      • Under 'Criterion 2' enter a grade of 15
      • Under 'Criterion 2' enter a comment of "Keep up the progress"
      • Under 'Criterion 3' enter a grade of 5
      • Click the "Save" button in the top right of the Grading interface
      • Click the 'Close' button
      • In a seperate browser
        • Navigate to Forum grading QA
        • Navigate to the grader report
        • Confirm the user Abed Nadir has a grade of 65 for 'Marking Guide Forum'
      • Back in the original browser
      • Click the 'Grade users' button
      • Confirm that the posts for user "Abed Nadir" render
      • Confirm that under 'Grade' confirm you see
        • Criterion 1
          • 'Out of 60'
            • 45
          • 'Additional comments'
            • 'Awesome motivation'
        • Criterion 2
          • 'Out of 30'
            • 15
          • 'Additional comments'
            • 'Keep up the progress'
        • Criterion 3
          • 'Out of 10'
            • 5
          • 'Additional comments'

      Rubric grading

      • Navigate to the course Forum grading QA
      • Navigate to the 'Rubric Forum'
      • Edit the Forum 'Rubric Forum'
      • Under the 'Whole forum grading' heading set the following
        • Grade:
          • Type: Point
          • Maximum grade: 100
        • Grading method: Rubric
        • Grade to pass: 75
      • Click 'Save changes'
      • Navigate back to the 'Rubric Forum'
      • Click the 'Grade users' button
      • Confirm that the posts for user "Abed Nadir" render
      • Confirm that under 'Grade' confirm you see
        • Criterion 1
          • A radio button for:
            • 'Not set - points' 
            • 'Level 0 0 points'
            • 'Level 1 1 points'
            • 'Level 2 2 points'
            • 'Level 3 3 points'
          • Additional feedback box
        • Criterion 2
          • A radio button for:
            • 'Not set - points'  
            • 'Level 0 0 points'
            • 'Level 1 1 points'
            • 'Level 2 2 points'
          • Additional feedback box
        • Criterion 3
          • A radio button for:
            • 'Not set - points'  
            • 'Level 0 0 points'
            • 'Level 1 1 points'
          • Additional feedback box
      • Confirm click the caret beside 'Criterion 1' collapses the 4 levels & 'Additional feedback'
      • Under 'Criterion 1' select 'Level 2'
      • Under 'Criterion 1' enter a comment of "Solid"
      • Under 'Criterion 2' select 'Level 1'
      • Under 'Criterion 3' select 'Level 0'
      • Click the "Save" button in the top right of the Grading interface
      • Click the 'Close' button
      • In a seperate browser
        • Navigate to Forum grading QA
        • Navigate to the grader report
        • Confirm the user Abed Nadir has a grade of 50 for 'Rubric Forum'
      • Back in the original browser
      • Click the 'Grade users' button
      • Confirm that the posts for user "Abed Nadir" render
      • Confirm that under 'Grade' confirm you see
        • Criterion 1
          • 'Level 2 2 points' is checked
          • 'Additional comments'
            • 'Solid'
        • Criterion 2
          • 'Level 1 1 points' is checked
        • Criterion 3
          • 'Level 0 0 points' is checked

      Repeat testing from MDL-66381 (with some slight changes)

      • Log in as an Admin
      • Navigate to the course Forum grading QA
      • Navigate to 'Points Forum'
      • Click the 'Grade users' button
      • Confirm a fullscreen Modal appears
      • Confirm the grading interface renders
      • Confirm that the posts for user "Abed Nadir" render
      • Click the "Search icon"
      • Confirm that all of the users appear below the "User picker"
        • Abed Nadir
        • Shirley Bennet
        • Annie Edison
        • Troy Barnes
        • Jeff Winger
        • Pierce Hawthorne
        • Britta Perry
        • Leonard Rodriguez
        • Alex Osbourne
        • Magnetic Attitude
        • Ian Duncan
        • Ben Chang
        • Sean Garrity
        • Craig Pelton
      • Click on the user "Jeff Winger"
      • Confirm that posts by "Jeff Winger" appear

      Test expermental nested view

      1. Log in as admin
      2. View the user's forum preferences
        • user menu (top right) > preferences > forum preferences
      3. Set "Use experimental nested discussion view" from "No" to "Yes"
      4. Navigate to the course Forum grading QA
      5. Navigate to 'Points Forum'
      6. Click the "Grade users"
      7. CONFIRM that the user's posts are now rendered using the experimental view (more similar to the attached screen shot)
      8. Click on the "view conversation" button in the posts region
      9. CONFIRM that a modal opens up and loads the full discussion in the same style as the posts in the grading interface
      Show
      NOTE The posts will render in the standard nested post view (which doesn't look like the attached mock up) unless you enable the experimental view (see the specific test for that). Repeat testing from MDL-66074 (with some small changes) Log in as an Admin Restore the course from the attached backup (backup-moodle2-course-5-mdl-66074-20191029-0201.mbz) Navigate to the course Forum grading QA Navigate to 'Points Forum' Confirm that a 'Grade users' button does not appear Edit the Forum 'Points Forum' Under the 'Whole forum grading' heading set the following Grade: Type: Point Maximum grade: 100 Grading method: Simple direct grading Grade to pass: 75 Log in as 'Ian Duncan' (username: T1, password: test) Points grading Navigate back to the 'Points Forum' Confirm that the 'Grade users' button now appears Click the 'Grade users' button Confirm a fullscreen Modal appears Confirm the grading interface renders Confirm that 'Points Forum > Grading' appears in the top left Confirm that the posts for user "Abed Nadir" render Enter under "Grade" 150" Confirm that you get a toast informing you that the grade save failed Enter under "Grade" set the field to empty Confirm that there was no error Enter under "Grade" 70 In a seperate browser Navigate to Forum grading QA Navigate to the grader report Confirm the user Abed Nadir has a grade of 70 for 'Points Forum' Back in the original browser Under the "Grading" pane find the User selector Next to the User "Abed Nadir" select the ">" button Confirm a loading spinner appears Confirm the loading spinner disappears Confirm "Abed Nadir" is no longer shown in the selector Confirm the posts by "Abed Nadir" are no longer shown Confirm that a toast stating "Grade saved for Abed Nadir" Confirm "Shirley Bennett" is shown in the selector Confirm that the posts for user "Shirley Bennett" render Confirm that one discussion heading is "Daylight savings time" Confirm that under the discussion "Daylight savings time" you see the post "Sorry I'm late. The sidewalk is more comfortable than it looks." Confirm that the post by "Shirley Bennett" shows under the post by Ian Duncan ""Sorry I'm late. The sidewalk is more comfortable than it looks." Click on the button 'View conversation' under the post 'Oh, that's not nice!' Confirm that a modal appears Confirm that the post 'Oh, that's not nice!' gets automatically scrolled to Scroll to the bottom of the modal Click the 'Cancel' button Add a grade of 55 for user "Shirley Bennett" Click the "Save" button in the top right of the Grading interface Back in the seperate browser Navigate to Forum grading QA Navigate to the grader report Confirm the user Shirley Bennett has a grade of 55 for 'Points Forum' Marking Guide grading Navigate to the course Forum grading QA Navigate to the 'Marking Guide Forum' Edit the Forum 'Marking Guide Forum' Under the 'Whole forum grading' heading set the following Grade: Type: Point Maximum grade: 100 Grading method: Marking guide Grade to pass: 75 Click 'Save changes' Navigate back to the 'Marking Guide Forum' Click the 'Grade users' button Confirm that the posts for user "Abed Nadir" render Confirm that under 'Grade' confirm you see Criterion 1 'Out of 60' 'Additional comments' Criterion 2 'Out of 30' 'Additional comments' Criterion 3 'Out of 10' 'Additional comments' Under 'Criterion 1' enter a grade of 45 Under 'Criterion 1' enter a comment of "Awesome motivation" Under 'Criterion 2' enter a grade of 15 Under 'Criterion 2' enter a comment of "Keep up the progress" Under 'Criterion 3' enter a grade of 5 Click the "Save" button in the top right of the Grading interface Click the 'Close' button In a seperate browser Navigate to Forum grading QA Navigate to the grader report Confirm the user Abed Nadir has a grade of 65 for 'Marking Guide Forum' Back in the original browser Click the 'Grade users' button Confirm that the posts for user "Abed Nadir" render Confirm that under 'Grade' confirm you see Criterion 1 'Out of 60' 45 'Additional comments' 'Awesome motivation' Criterion 2 'Out of 30' 15 'Additional comments' 'Keep up the progress' Criterion 3 'Out of 10' 5 'Additional comments' Rubric grading Navigate to the course Forum grading QA Navigate to the 'Rubric Forum' Edit the Forum 'Rubric Forum' Under the 'Whole forum grading' heading set the following Grade: Type: Point Maximum grade: 100 Grading method: Rubric Grade to pass: 75 Click 'Save changes' Navigate back to the 'Rubric Forum' Click the 'Grade users' button Confirm that the posts for user "Abed Nadir" render Confirm that under 'Grade' confirm you see Criterion 1 A radio button for: 'Not set - points'  'Level 0 0 points' 'Level 1 1 points' 'Level 2 2 points' 'Level 3 3 points' Additional feedback box Criterion 2 A radio button for: 'Not set - points'   'Level 0 0 points' 'Level 1 1 points' 'Level 2 2 points' Additional feedback box Criterion 3 A radio button for: 'Not set - points'   'Level 0 0 points' 'Level 1 1 points' Additional feedback box Confirm click the caret beside 'Criterion 1' collapses the 4 levels & 'Additional feedback' Under 'Criterion 1' select 'Level 2' Under 'Criterion 1' enter a comment of "Solid" Under 'Criterion 2' select 'Level 1' Under 'Criterion 3' select 'Level 0' Click the "Save" button in the top right of the Grading interface Click the 'Close' button In a seperate browser Navigate to Forum grading QA Navigate to the grader report Confirm the user Abed Nadir has a grade of 50 for 'Rubric Forum' Back in the original browser Click the 'Grade users' button Confirm that the posts for user "Abed Nadir" render Confirm that under 'Grade' confirm you see Criterion 1 'Level 2 2 points' is checked 'Additional comments' 'Solid' Criterion 2 'Level 1 1 points' is checked Criterion 3 'Level 0 0 points' is checked Repeat testing from MDL-66381 (with some slight changes) Log in as an Admin Navigate to the course Forum grading QA Navigate to 'Points Forum' Click the 'Grade users' button Confirm a fullscreen Modal appears Confirm the grading interface renders Confirm that the posts for user "Abed Nadir" render Click the "Search icon" Confirm that all of the users appear below the "User picker" Abed Nadir Shirley Bennet Annie Edison Troy Barnes Jeff Winger Pierce Hawthorne Britta Perry Leonard Rodriguez Alex Osbourne Magnetic Attitude Ian Duncan Ben Chang Sean Garrity Craig Pelton Click on the user "Jeff Winger" Confirm that posts by "Jeff Winger" appear Test expermental nested view Log in as admin View the user's forum preferences user menu (top right) > preferences > forum preferences Set "Use experimental nested discussion view" from "No" to "Yes" Navigate to the course Forum grading QA Navigate to 'Points Forum' Click the "Grade users" CONFIRM that the user's posts are now rendered using the experimental view (more similar to the attached screen shot) Click on the "view conversation" button in the posts region CONFIRM that a modal opens up and loads the full discussion in the same style as the posts in the grading interface
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66893-master-3
    • Sprint:
      Internationals - 3.8 Alpha

      Description

      Once the majority of the forum grading interface functionality has been implemented, we should make the UI match the designs.

        Attachments

        1. backup-moodle2-course-5-mdl-66074-20191029-0201.mbz
          664 kB
        2. ExperimentalNestedView.png
          ExperimentalNestedView.png
          168 kB
        3. markingguide.png
          markingguide.png
          112 kB
        4. photo_2019-10-23 15.03.15.jpeg
          photo_2019-10-23 15.03.15.jpeg
          220 kB
        5. repeattestingmdl-66381.png
          repeattestingmdl-66381.png
          206 kB
        6. rubric.png
          rubric.png
          171 kB
        7. Screenshot_1.png
          Screenshot_1.png
          208 kB
        8. Screenshot_2.png
          Screenshot_2.png
          237 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 2 days, 4 hours, 30 minutes
                  1w 2d 4h 30m