Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66897

'The grades were not saved...' should not be displayed as a success message

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as Admin.
      2. Create a Course.
      3. Enrol a Student in the Course.
      4. Create an Assignment in the Course.
      5. Go to the Assignment > View all submissions (tab1), with quick grading enabled
      6. Open the 'View all submissions' page again in a separate tab (tab2), with quick grading enabled.
      7. In tab1:
        1. Enter a grade for the Student in the table's Grade column.
        2. Press 'Save all quick grading changes'.
      8. Make sure a success notification message (GREEN) is displayed ('The grade changes were saved'). 
      9. In tab2 (without reloading the page after tab1 grade was saved):
        1. Enter a grade for the Student in the table's Grade column.
        2. Press 'Save all quick grading changes'.
      10. Make sure an error notification message (RED) is displayed ('The grades were not saved because someone has modified one or more records more recently than when you loaded the page.').
      Show
      Login as Admin. Create a Course. Enrol a Student in the Course. Create an Assignment in the Course. Go to the Assignment > View all submissions (tab1), with quick grading enabled Open the 'View all submissions' page again in a separate tab (tab2), with quick grading enabled. In tab1: Enter a grade for the Student in the table's Grade column. Press 'Save all quick grading changes'. Make sure a success notification message (GREEN) is displayed ('The grade changes were saved').   In tab2 (without reloading the page after tab1 grade was saved): Enter a grade for the Student in the table's Grade column. Press 'Save all quick grading changes'. Make sure an error notification message (RED) is displayed ('The grades were not saved because someone has modified one or more records more recently than when you loaded the page.').
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
      MDL-66897-37-1
    • Pull 3.8 Branch:
      MDL-66897-38-1
    • Pull Master Branch:
      MDL-66897-master-1

      Description

      When two or more people try to submit quick grades at the same time it correctly only allows the first person to submit and gives the rest of them the error `"The grades were not saved because someone has modified one or more records more recently than when you loaded the page."`. However, this error message is displayed in the "success" style which leads to graders thinking they have successfully saved their grades.

       

      Reproduction:

      1. Create an assignment
      2. Go to grade the assignment in quick grading mode
      3. Open two tabs to quick grading mode
      4. Enter data in both tabs
      5. Save the first tab. It should display "The grade changes were saved"
      6. Save the second tab.

       

      Expected:

      The second tab should then display "The grades were not saved because someone has modified one or more records more recently than when you loaded the page." in an error style to signify that something went wrong.

       

      Actual:

      The second tab will then display "The grades were not saved because someone has modified one or more records more recently than when you loaded the page.", but it does so in the "success" style.

       

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            thislooksfun thislooksfun
            Peer reviewer:
            Peter Dias
            Integrator:
            Jun Pataleta
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 52 minutes
                2h 52m