Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66917

No validation that uploaded (from zip) plugin has higher version than installed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      Ensure your [dirroot]/local folder is writeable by the webserver (so we can use the plugin uploader tool), e.g.

      1. chmod 777 local

      Install plugin

      1. Login as admin
      2. Navigate to Plugins > Install plugins in Site administration
      3. Upload local_mdl66917-2020020100.zip and press Install plugin from the zip file
      4. Confirm you see the message "Validation successful, installation can continue"
      5. Press Continue
      6. Press Upgrade Moodle database now
      7. Confirm install succeeds
      8. Press Continue

      Upgrade plugin

      1. Navigate to Plugins > Install plugins in Site administration
      2. Upload local_mdl66917-2020022500.zip and press Install plugin from the zip file
      3. Confirm you see the warning "Target location already exists and will be removed"
      4. Confirm you see the message "Validation successful, installation can continue"
      5. Press Continue
      6. Press Upgrade Moodle database now
      7. Confirm upgrade succeeds
      8. Press Continue

      Downgrade plugin

      1. Navigate to Plugins > Install plugins in Site administration
      2. Upload local_mdl66917-2020020100.zip and press Install plugin from the zip file
      3. Confirm you see the error "A higher version of this plugin is already installed [2020022500]"
      4. Confirm you see the message "Installation aborted due to validation failure
      Show
      Setup Ensure your [dirroot] /local folder is writeable by the webserver (so we can use the plugin uploader tool), e.g. chmod 777 local Install plugin Login as admin Navigate to Plugins > Install plugins in Site administration Upload local_mdl66917-2020020100.zip and press Install plugin from the zip file Confirm you see the message "Validation successful, installation can continue" Press Continue Press Upgrade Moodle database now Confirm install succeeds Press Continue Upgrade plugin Navigate to Plugins > Install plugins in Site administration Upload local_mdl66917-2020022500.zip and press Install plugin from the zip file Confirm you see the warning "Target location already exists and will be removed" Confirm you see the message "Validation successful, installation can continue" Press Continue Press Upgrade Moodle database now Confirm upgrade succeeds Press Continue Downgrade plugin Navigate to Plugins > Install plugins in Site administration Upload local_mdl66917-2020020100.zip and press Install plugin from the zip file Confirm you see the error "A higher version of this plugin is already installed [2020022500] " Confirm you see the message "Installation aborted due to validation failure
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:

      Description

      if I go to "Site administration>Plugins>Install plugins" and upload a zip with a lower version than installed plugin, it will not check it

      However moodle actually detects the version from the zip and displays it on the confirmation screen, it just does not compare it with the installed one

      To test: donwload these two archives
      https://github.com/moodlehq/moodle-local_codechecker/archive/master.zip
      https://github.com/moodlehq/moodle-local_codechecker/archive/v2.9.2.zip
      Install the first one
      Try to install the second one (it has lower version) - there will be no validation and the newer code will be overridden. Since this is a zip install there is no "undo"

        Attachments

        1. local_mdl66917-2020020100.zip
          1 kB
        2. local_mdl66917-2020022500.zip
          1 kB
        3. Screenshot_1.png
          Screenshot_1.png
          126 kB
        4. Screenshot_2.png
          Screenshot_2.png
          166 kB

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Marina Glancy
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jul/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 50 minutes
                  1h 50m