Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.5.8, 3.6.6, 3.7, 3.8
-
Component/s: Automated functional tests (behat)
-
Labels:
-
Testing Instructions:
For every branch
- Copy the attached before_reports_before.feature
to lib/tests/behat - Init behat (php admin/tool/behat/cli/init.php)
- Take note of the command given at the end...
- Run behat using the command from the previous step with --suite default --name 'Before reports before'
- Verify that:
- There is 1 scenario executed and it fails.
- The scenario is named "Fail because Calendar in not before Dashboard"
- The last line of the failure is like this (special attention to the "before" word being present):
'Calendar' 'link' does not appear before 'Dashboard' 'link' (Behat\Mink\Exception\ExpectationException)
That's all!
For every branch Copy the attached before_reports_before.feature to lib/tests/behat Init behat ( php admin/tool/behat/cli/init.php ) Take note of the command given at the end... Run behat using the command from the previous step with --suite default --name 'Before reports before' Verify that: There is 1 scenario executed and it fails. The scenario is named "Fail because Calendar in not before Dashboard" The last line of the failure is like this (special attention to the "before" word being present): 'Calendar' 'link' does not appear before 'Dashboard' 'link' (Behat\Mink\Exception\ExpectationException) That's all! - Copy the attached before_reports_before.feature
-
Affected Branches:MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
-
Fixed Branches:MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Detected when looking for MDL-66553 failures.
There is an obvious (copy/paste) error in the error message of the should_appear_before() step.
Whenever it fails, currently this is shown (real example):
Then "C question 3 name" "checkbox" should appear before "A question 1 name" "checkbox"
|
Problem: 'C question 3 name' 'checkbox' does not appear AFTER 'A question 1 name' 'checkbox'
|
That is clearly, an oxymoron, heh. The "Problem" should be, instead:
Problem: 'C question 3 name' 'checkbox' does not appear BEFORE 'A question 1 name' 'checkbox'
|
aka, s/after/before
that is exactly what is being checked by the step.
