Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66930

In edit quiz (Boost/Classic theme), image type icons are too large and have strange classes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.6, 3.7.2, 3.8
    • Fix Version/s: 3.6.7, 3.7.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Test in Clean and Boost (3.6) as well as Classic and Boost (3.7 and 3.8)
      2. As teacher, add a test to your course and add a question.
      3. In that view (…/mod/quiz/edit.php?cmid=xxxx) verify that the question type icons are 16px high and wide
      4. Verify there is only class="icon activityicon" in the source for the icons.

       

      Note that I added a small right hand side padding, the icons and cogs were almost touching before.

      Show
      Test in Clean and Boost (3.6) as well as Classic and Boost (3.7 and 3.8) As teacher, add a test to your course and add a question. In that view (…/mod/quiz/edit.php?cmid=xxxx) verify that the question type icons are 16px high and wide Verify there is only class="icon activityicon" in the source for the icons.   Note that I added a small right hand side padding, the icons and cogs were almost touching before.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-66930-master

      Description

      When you edit a quiz, the question type icons have risen to a larger size, which breaks the previous look.

      To reproduce go in a quiz to the 'edit quiz' interface e.g. https://qa.moodledemo.net/mod/quiz/edit.php?cmid=30 as a teacher.

      I'm pretty sure this must be a regression of some fix. Classes "icon icon activityicon" do seem unnatural to me, too.

        Attachments

          Activity

            People

            Assignee:
            lucaboesch Luca Bösch
            Reporter:
            lucaboesch Luca Bösch
            Peer reviewer:
            Tim Hunt
            Integrator:
            Jake Dallimore
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 50 minutes
                50m