Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66954

Rename filter_h5p to filter_displayh5p

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.8
    • 3.8
    • H5P
    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-66954-master
    • Hide

      Check filter is still working as expected

      Prerequisites:

      • Having multiple H5P content URLs:
      • Go to admin -> plugins -> filters -> Display h5p and, in "Allowed sources", add this:

        https://h5p.org/h5p/embed/[id]
        https://h5p.org/h5p/embed/[id]
        https://moodle.h5p.com/content/[id]

      Test

      1. Check in Site administration > Plugins > Filters > Manage filters 'Convert URLs into links and images' filter is Disabled or, in case it is On, is ordered below Display H5P filter.
      2. Create a course C1.
      3. In course C1, add a Label anywhere.
      4. In the Label text Atto editor, copy and paste  the following text using the HTML/code view:

      <div>1.valid URL: https://h5p.org/h5p/embed/580638</div>
      <div>2.another valid URL: https://h5p.org/h5p/embed/6729</div>
      <div>3.non valid URL: https://moodle.org</div>
      <div>4.URL inside a link tag: <a href="https://h5p.org/h5p/embed/6729">link</a></div>
      <div>5.paragraph with a valid URL https://h5p.org/h5p/embed/580638 inside</div>
      <div>6.a valid URL ended by '/embed': https://moodle.h5p.com/content/1290729733828858779/embed</div>
      <div>7.an h5p.com valid URL not ended by '/embed': https://moodle.h5p.com/content/1290729733828858779</div>

      1. Confirm that the H5P contents of 1, 2, 5, 6 and 7 are displayed.
      Show
      Check filter is still working as expected Prerequisites: Having multiple H5P content URLs: Go to admin -> plugins -> filters -> Display h5p and, in "Allowed sources", add this: https://h5p.org/h5p/embed/[id] https://h5p.org/h5p/embed/[id] https://moodle.h5p.com/content/[id] Test Check in Site administration > Plugins > Filters > Manage filters 'Convert URLs into links and images' filter is Disabled or, in case it is On, is ordered below Display H5P filter. Create a course C1. In course C1, add a Label anywhere. In the Label text Atto editor, copy and paste  the following text using the HTML/code view : <div>1.valid URL: https://h5p.org/h5p/embed/580638</div> <div>2.another valid URL: https://h5p.org/h5p/embed/6729</div> <div>3.non valid URL: https://moodle.org</div> <div>4.URL inside a link tag: <a href="https://h5p.org/h5p/embed/6729">link</a></div> <div>5.paragraph with a valid URL https://h5p.org/h5p/embed/580638 inside</div> <div>6.a valid URL ended by '/embed': https://moodle.h5p.com/content/1290729733828858779/embed</div> <div>7.an h5p.com valid URL not ended by '/embed': https://moodle.h5p.com/content/1290729733828858779</div> Confirm that the H5P contents of 1, 2, 5, 6 and 7 are displayed.
    • H5P Sprint Relase 3.8

    Description

      There's an existing filter_h5p in Moodle plugins directory: https://moodle.org/plugins/filter_h5p

      So we need to rename new core filter to avoid collisions.

      New name for core H5P filter will be filter_displayh5p.

      Attachments

        Issue Links

          Activity

            People

              amaia Amaia Anabitarte
              amaia Amaia Anabitarte
              Carlos Escobedo Carlos Escobedo
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Gladys Basiana Gladys Basiana
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 13 minutes
                  1d 1h 13m