Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66958

Review of 'Grade saved' message when no changes to grade or feedback have been made

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      • Log in as an Admin
      • Restore the course from the attached backup
      • Navigate to the course Forum grading QA

      Points grading test

      • Navigate to 'Points Forum'
      • Click the 'Grade users' button
      • Confirm the grading interface renders
      • Confirm that the posts for user "Abed Nadir" render
      • Click the 'Next' user button
      • Confirm that the "Grade saved for Abed Nadir" toast notification does not show
      • Confirm that the posts for user "Shirley Bennett" render
      • Enter a grade of 65
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show

      Scale grading test

      • Navigate to 'Scales Forum'
      • Click the 'Grade users' button
      • Confirm the grading interface renders
      • Confirm that the posts for user "Abed Nadir" render
      • Click the 'Next' user button
      • Confirm that the "Grade saved for Abed Nadir" toast notification does not show
      • Confirm that the posts for user "Shirley Bennett" render
      • Select a grade of "Competent"
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show

      Rubric grading test

      • Navigate to 'Rubric Forum'
      • Click the 'Grade users' button
      • Confirm the grading interface renders
      • Confirm that the posts for user "Abed Nadir" render
      • Click the 'Next' user button
      • Confirm that the "Grade saved for Abed Nadir" toast notification does not show
      • Confirm that the posts for user "Shirley Bennett" render
      • Give Shirley any grades you wish
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show
      • Click the 'Next' user button
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does not show
      • Click the 'Next' user button
      • Under one of the criterions "Additional feedback" text areas enter some text
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show

      Marking Guide grading test

      • Navigate to 'Marking Guide Forum'
      • Click the 'Grade users' button
      • Confirm the grading interface renders
      • Confirm that the posts for user "Abed Nadir" render
      • Click the 'Next' user button
      • Confirm that the "Grade saved for Abed Nadir" toast notification does not show
      • Confirm that the posts for user "Shirley Bennett" render
      • Give Shirley any grades you wish
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show
      • Click the 'Next' user button
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does not show
      • Click the 'Next' user button
      • Under one of the criterions "Additional comments" text areas enter some text
      • Click the 'Previous' user button
      • Confirm that the "Grade saved for Shirley Bennett" toast notification does show
      Show
      Prerequisites Log in as an Admin Restore the course from the attached backup Navigate to the course Forum grading QA Points grading test Navigate to 'Points Forum' Click the 'Grade users' button Confirm the grading interface renders Confirm that the posts for user "Abed Nadir" render Click the 'Next' user button Confirm that the "Grade saved for Abed Nadir" toast notification does not show Confirm that the posts for user "Shirley Bennett" render Enter a grade of 65 Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show Scale grading test Navigate to 'Scales Forum' Click the 'Grade users' button Confirm the grading interface renders Confirm that the posts for user "Abed Nadir" render Click the 'Next' user button Confirm that the "Grade saved for Abed Nadir" toast notification does not show Confirm that the posts for user "Shirley Bennett" render Select a grade of "Competent" Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show Rubric grading test Navigate to 'Rubric Forum' Click the 'Grade users' button Confirm the grading interface renders Confirm that the posts for user "Abed Nadir" render Click the 'Next' user button Confirm that the "Grade saved for Abed Nadir" toast notification does not show Confirm that the posts for user "Shirley Bennett" render Give Shirley any grades you wish Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show Click the 'Next' user button Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does not show Click the 'Next' user button Under one of the criterions "Additional feedback" text areas enter some text Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show Marking Guide grading test Navigate to 'Marking Guide Forum' Click the 'Grade users' button Confirm the grading interface renders Confirm that the posts for user "Abed Nadir" render Click the 'Next' user button Confirm that the "Grade saved for Abed Nadir" toast notification does not show Confirm that the posts for user "Shirley Bennett" render Give Shirley any grades you wish Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show Click the 'Next' user button Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does not show Click the 'Next' user button Under one of the criterions "Additional comments" text areas enter some text Click the 'Previous' user button Confirm that the "Grade saved for Shirley Bennett" toast notification does show
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
    • Sprint:
      Internationals - 3.8 Alpha

      Description

      When navigating to the next student to be graded the 'Grade saved' message is displayed regardless of whether a grade was entered or anything was changed. 

      As a part of this we should pull from the relevant grading methods if the user has been graded or not. As opposed to comparing a before & after of the grading form.

      Part of MDL-66952

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 4 hours, 25 minutes
                  1d 4h 25m