Loading...

XML

Word

Printable

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
Prepare Moodle for PHP 7.4
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-66968~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-66968~1...MDL-66968
Testing Instructions:
Hide

Verify that https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/611/ (it uses php74rc4) ends without any error related to "array_key_exists". (open console and search for it. Note that, for the time being, there are lots of errors and failures, here we are only interested in the "array_key_exists" ones)

Ensure that automated tests (phpunit and behat) don't fail for php71 and php73.
Show
Verify that https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/611/ (it uses php74rc4) ends without any error related to "array_key_exists" . (open console and search for it. Note that, for the time being, there are lots of errors and failures, here we are only interested in the "array_key_exists" ones) Ensure that automated tests (phpunit and behat) don't fail for php71 and php73.

It has been advised since long ago that the ability of array_key_exists() to work on object properties was far from ideal.

With php74 such uses have become officially deprecated with message:

array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead

This issue is about perform the needed replacements, ensuring that everything continues working ok.

Testing discovered

MDL-66980 Incorrect logic in question_bank::load_many_for_cache

Estimated:

Not Specified

Remaining:

Logged:

1d 3h