[MDL-66970] Incorrect use of ?? in enrolment_active_during_analysis_time - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.8
Fix Version/s: 3.8
Component/s: Analytics
Labels:
- ci
- triaged

Testing Instructions:

Hide

Unit tests should pass

Show
Unit tests should pass
Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Master Branch:
~~MDL-66970~~_master
Pull Master Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-66970_master~2...MDL-66970_master

Description

enrolment_active_during_analysis_time uses ?? as if the condition to return the first element would be a !empty() while it is actually a isset(), my bad.

This is a regression introduced by ~~MDL-66254~~

Attachments

Issue Links

is a regression caused by

MDL-66254 Require enrolments to be active for most of the analysis interval

Closed

Activity

People

Assignee:: David Monllaó

Reporter:: David Monllaó

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Sara Arjona (@sarjona)

Component watchers:: Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 21/Oct/19 8:55 AM

Updated:: 22/Oct/19 9:14 PM

Resolved:: 22/Oct/19 9:14 PM

Fix Release Date:: 18/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 46m