Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66980

Incorrect logic in question_bank::load_many_for_cache

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.6, 3.7.2, 3.8
    • Fix Version/s: 3.6.7, 3.7.3
    • Component/s: Questions
    • Labels:

      Description

      Eloy spotted this while working on MDL-66968.

      https://github.com/moodle/moodle/blob/aaff6692a1aa1827cb5c1c69910302d8cbf99379/question/engine/bank.php#L613 should be if (!array_key_exists($id, $questiondata)).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Jan Dageförde
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 11 minutes
                  11m