[MDL-66980] Incorrect logic in question_bank::load_many_for_cache - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.6, 3.7.2, 3.8
Fix Version/s: 3.6.7, 3.7.3
Component/s: Questions
Labels:
- ci
- triaged

Testing Instructions:

Hide

The automated tests are sufficient for this.

Show
The automated tests are sufficient for this.
Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull 3.6 Branch:
~~MDL-66980~~_36
Pull 3.6 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_36_STABLE...MDL-66980_36
Pull 3.7 Branch:
~~MDL-66980~~_37
Pull 3.7 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_37_STABLE...MDL-66980_37
Pull Master Branch:
~~MDL-66980~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-66980

Description

Eloy spotted this while working on ~~MDL-66968~~.

https://github.com/moodle/moodle/blob/aaff6692a1aa1827cb5c1c69910302d8cbf99379/question/engine/bank.php#L613 should be if (!array_key_exists($id, $questiondata)).

Attachments

Issue Links

Discovered while testing

MDL-66968 Remove array_key_exists() on objects

Closed

Activity

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Peer reviewer:

Jan Dageförde

Integrator:

Eloy Lafuente (stronk7)

Tester:

CiBoT

Participants:

CiBoT, Eloy Lafuente (stronk7), Jan Dageförde, Sara Arjona (@sarjona), Tim Hunt

Component watchers:

Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

21/Oct/19 5:41 PM

Updated:

22/Oct/19 9:14 PM

Resolved:

22/Oct/19 9:14 PM

Fix Release Date:

11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

11m