Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66989

Incorrect 'More help' link in Upload users help popup

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as Admin.
      2. Go to 'Site administration > Users > Accounts > Upload users'.
      3. Click on the help icon next the the "Upload users" title.
      4. Check that there is a link at the bottom of the help dialogue that says "More help".
      5. Click the link. Check that you are redirected to a help (docs) page about Uploading users.
      Show
      Login as Admin. Go to 'Site administration > Users > Accounts > Upload users'. Click on the help icon next the the "Upload users" title. Check that there is a link at the bottom of the help dialogue that says "More help". Click the link. Check that you are redirected to a help (docs) page about Uploading users.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66989-master

      Description

      A 'More help' link was added to the Upload users help popup in MDL-66705 by adding the line

      <a href="https://docs.moodle.org/en/Upload_users" target="_blank">More help</a>

      to the lang string uploadusers_help.

      This is incorrect because it doesn't allow for a link to Moodle Docs in the user's language, or to the appropriate version wiki.

      Instead, the 'More help' link should be implemented as described in https://docs.moodle.org/dev/String_API#More_help_links with a short relative path of admin/tool/uploaduser/index as for the 'Moodle Docs for this page' link.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Geshoski Mihail Geshoski
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Paul Holden
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, cameron1729, David Mudrák (@mudrd8mz), Helen Foster
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 32 minutes
                  32m