Details
-
Sub-task
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.8, 3.9
-
MOODLE_38_STABLE, MOODLE_39_STABLE
-
MOODLE_38_STABLE
-
Description
The Bennu library that we are using since 2005 is not php74 compliant.
Our one is based in really old version 0.1 and heavily customized since then. So there isn't any library upgrade to perform but straight fixes (documented).
Here we are looking for all the curly brackets being used for array/string indexes (there maybe other changes to perform).
$ ag '(\$[0-9a-zA-Z_]+|\))(\[[\w$]+\])?{[^\n=}]+}' --php | sort | uniq
|
iCalendar_properties.php:1282: if($value{$i} == ';' && !$escch) {
|
iCalendar_properties.php:1288: $escch = ($value{$i} == '\\');
|
iCalendar_properties.php:1309: if($parts[0]{0} < '1' || $parts[0]{0} > '4') {
|
iCalendar_properties.php:1316: if($len > 5 || $parts[0]{$len - 1} == '.') {
|
iCalendar_properties.php:1321: if(($i & 1) == 1 && $parts[0]{$i} != '.') {
|
iCalendar_properties.php:1325: else if(($i & 1) == 0 && ($parts[0]{$i} < '0' || $parts[0]{$i} > '9')) {
|
iCalendar_properties.php:1349: $thischar = $parts[$i]{$j};
|
iCalendar_properties.php:1350: $nextchar = $parts[$i]{$j + 1};
|
iCalendar_properties.php:740: return ($value{0} != '-');
|
iCalendar_properties.php:764: if($value{$pos - 1} != 'Z') {
|
iCalendar_properties.php:768: if($value{$pos + 1} != 'P' && substr($value, -1) != 'Z') {
|
iCalendar_rfc2445.php:144: $regexp = '#^[a-zA-Z0-9]+[_a-zA-Z0-9\-]*(\.[_a-z0-9\-]+)*@(([0-9a-zA-Z\-]+\.)+[a-zA-Z][0-9a-zA-Z\-]+|([0-9]{1,3}\.){3}[0-9]{1,3})$#';
|
iCalendar_rfc2445.php:147: $regexp = '#^//(.+(:.*)?@)?(([0-9a-zA-Z\-]+\.)+[a-zA-Z][0-9a-zA-Z\-]+|([0-9]{1,3}\.){3}[0-9]{1,3})(:[0-9]{1,5})?(/.*)?$#';
|
iCalendar_rfc2445.php:165: $ch = $value{$i};
|
iCalendar_rfc2445.php:214: return($value{8} == 'T' &&
|
iCalendar_rfc2445.php:231: if($value{0} == '+' || $value{0} == '-') {
|
iCalendar_rfc2445.php:236: if($value{0} != 'P') {
|
iCalendar_rfc2445.php:245: $ch = $value{$i};
|
iCalendar_rfc2445.php:312: switch($value{$i}) {
|
iCalendar_rfc2445.php:352: if($value{0} == '+' || $value{0} == '-') {
|
iCalendar_rfc2445.php:387: return ($parts[1]{0} != '-');
|
iCalendar_rfc2445.php:755: if($value{0} != '+' && $value{0} != '-') {
|
