Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66319 Remove curly brace syntax for accessing array elements and string offsets
  3. MDL-67031

Required changes to make S3 lib PHP 7.4 compliant (curly braces)

XMLWordPrintable

    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • Hide
      1. run the following command (requires ag, although advanced grep versions should be able to run it, after all, it's just a regular expression:
        N.b. If you have ack, you should be able to replace ag with ack in the command below. (sudo apt-get install ack) 

        $ ag '(\$[0-9a-zA-Z_]+|\))(\[['\''"\w$]+\])?{[^\n=}]+}'  repository/s3 --php

      2. Verify that you get ZERO matches, that means that there aren't remaining cases.
      3. Using moodle-docker (or any >= PHP7.4 RC4 installation) install phpunit (init.php).
      4. Verify that there isn't any PHP notice/warning related with repository/s3 stuff. (Be warned that there may be lots of notices/warnings/errors, here we are only interested in the repository/s3 ones).
      5. Run phpunit (with that PHP7.4 version).
      6. Verify that there isn't any PHP notice/warning related with repository/s3. (Be warned that there are lots of notices/warning/errors and failures, here we are only interested in the repository/s3 ones
      7. Verify that travis is passing for php71 and php73 (specifically repository ones).
      Show
      run the following command (requires ag , although advanced grep versions should be able to run it, after all, it's just a regular expression: N.b. If you have ack, you should be able to replace ag with ack in the command below. (sudo apt-get install ack) $ ag '(\$[0-9a-zA-Z_]+|\))(\[['\''"\w$]+\])?{[^\n=}]+}' repository/s3 --php Verify that you get ZERO matches, that means that there aren't remaining cases. Using moodle-docker (or any >= PHP7.4 RC4 installation) install phpunit (init.php). Verify that there isn't any PHP notice/warning related with repository/s3 stuff. (Be warned that there may be lots of notices/warnings/errors, here we are only interested in the repository/s3 ones). Run phpunit (with that PHP7.4 version). Verify that there isn't any PHP notice/warning related with repository/s3. (Be warned that there are lots of notices/warning/errors and failures, here we are only interested in the repository/s3 ones Verify that travis is passing for php71 and php73 (specifically repository ones).

      We are currently using the S3 php class v0.5.1 from 2015. It doesn't seem to be really maintained at all:

      Also, for the purposes of php74 compliance, there is an incorrect use of curly braces in it:

      ag '(\$[0-9a-zA-Z_]+|\))(\[['\''"\w$]+\])?{[^\n=}]+}' repository/s3 --php
      		 
       
      		 
      repository/s3/S3.php:2357:	$this->response->headers['hash'] = $value{0} == '"' ? substr($value, 1, -1) : $value;

      So this issue is about:
      1) fix the use above to be php74 compliant, documenting it in readme.
      2) create a new issue because it's really, really, old stuff and we should look for replacement.

        1. Confirmed fixed.png
          Confirmed fixed.png
          109 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Glyn (Mathew) May Glyn (Mathew) May
            Jake Dallimore Jake Dallimore
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.