[MDL-67093] Advanced grading uses get_context_info_array to get modname - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.6, 3.7.2
Fix Version/s: 3.6.7, 3.7.3
Component/s: Grading methods, Performance
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-67093~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/e04a73ccc0...MDL-67093-master
Testing Instructions:
Hide

This will be tested by CI and the performance testing servers

For specific testing this requires reverting the commit and comparing the number of DB calls.
One easy place to do so is on the front page of any assignment.

View an assignment

Refresh the page a few times until the DB read count stabilises

Take note of the number of DB reads

Revert the patch

Refresh the page a few times until the DB read count stabilises

Confirm that the read count when the patch is present is lower than without it.
Show
This will be tested by CI and the performance testing servers For specific testing this requires reverting the commit and comparing the number of DB calls. One easy place to do so is on the front page of any assignment. View an assignment Refresh the page a few times until the DB read count stabilises Take note of the number of DB reads Revert the patch Refresh the page a few times until the DB read count stabilises Confirm that the read count when the patch is present is lower than without it.

Description

Advanced grading uses get_context_info_array to get modname
This is stupidly expensive and we can easily cut out multiple queries by using get_fast_modinfo() as we almost always have this information cached.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-11-05-09-26-18-998.png
127 kB
05/Nov/19 9:26 AM

Issue Links

Discovered while testing

MDL-66074 Epic: Create forum grading interface

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Mathew May

Integrator:: Jake Dallimore

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Jake Dallimore, Janelle Barcega, Mathew May

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 31/Oct/19 12:38 PM

Updated:: 05/Nov/19 9:25 PM

Resolved:: 05/Nov/19 9:25 PM

Fix Release Date:: 11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 35m