Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67093

Advanced grading uses get_context_info_array to get modname

    XMLWordPrintable

Details

    • MOODLE_36_STABLE, MOODLE_37_STABLE
    • MOODLE_36_STABLE, MOODLE_37_STABLE
    • MDL-67093-master
    • Hide

      This will be tested by CI and the performance testing servers

      For specific testing this requires reverting the commit and comparing the number of DB calls.
      One easy place to do so is on the front page of any assignment.

      1. View an assignment
      2. Refresh the page a few times until the DB read count stabilises
        1. Take note of the number of DB reads
      3. Revert the patch
      4. Refresh the page a few times until the DB read count stabilises
        1. Confirm that the read count when the patch is present is lower than without it.
      Show
      This will be tested by CI and the performance testing servers For specific testing this requires reverting the commit and comparing the number of DB calls. One easy place to do so is on the front page of any assignment. View an assignment Refresh the page a few times until the DB read count stabilises Take note of the number of DB reads Revert the patch Refresh the page a few times until the DB read count stabilises Confirm that the read count when the patch is present is lower than without it.

    Description

      Advanced grading uses get_context_info_array to get modname
      This is stupidly expensive and we can easily cut out multiple queries by using get_fast_modinfo() as we almost always have this information cached.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Mathew May Mathew May
              Jake Dallimore Jake Dallimore
              Janelle Barcega Janelle Barcega
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 35 minutes
                  1h 35m