Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67094

When advanced grading is active both settings and navigation repeat DB queries

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.8, 3.6.6, 3.7.2
    • Fix Version/s: None
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE

      Description

      When viewing any activity with advanced grading present, e.g. assignment, _both- the global navigation and settings navigation call extend_navigation leading to duplicate loading of anything and everything associated with advanced grading.

      #0  grading_manager->get_active_method() called at [/Users/nicols/Sites/moodles/im/moodle/grade/grading/lib.php:560]
      #1  grading_manager->get_active_controller() called at [/Users/nicols/Sites/moodles/im/moodle/grade/grading/lib.php:502]
      #2  grading_manager->extend_navigation() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:2280]
      #3  global_navigation->load_activity() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:1437]
      #4  global_navigation->initialise() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:3960]
      #5  flat_navigation->initialise() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:781]
      #6  moodle_page->magic_get_flatnav() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:830]
      #7  moodle_page->__get() called at [/Users/nicols/Sites/moodles/im/moodle/theme/boost/layout/columns2.php:56]
      #8  include(/Users/nicols/Sites/moodles/im/moodle/theme/boost/layout/columns2.php) called at [/Users/nicols/Sites/moodles/im/moodle/lib/outputrenderers.php:1374]
      #9  core_renderer->render_page_layout() called at [/Users/nicols/Sites/moodles/im/moodle/lib/outputrenderers.php:1304]
      #10 core_renderer->header() called at [/Users/nicols/Sites/moodles/im/moodle/mod/forum/view.php:158]
      #0  grading_manager->get_active_method() called at [/Users/nicols/Sites/moodles/im/moodle/grade/grading/lib.php:462]
      #1  grading_manager->extend_settings_navigation() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:4665]
      #2  settings_navigation->load_module_settings() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:4147]
      #3  settings_navigation->initialise() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:769]
      #4  moodle_page->magic_get_settingsnav() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:830]
      #5  moodle_page->__get() called at [/Users/nicols/Sites/moodles/im/moodle/lib/navigationlib.php:4007]
      #6  flat_navigation->initialise() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:781]
      #7  moodle_page->magic_get_flatnav() called at [/Users/nicols/Sites/moodles/im/moodle/lib/pagelib.php:830]
      #8  moodle_page->__get() called at [/Users/nicols/Sites/moodles/im/moodle/theme/boost/layout/columns2.php:56]
      #9  include(/Users/nicols/Sites/moodles/im/moodle/theme/boost/layout/columns2.php) called at [/Users/nicols/Sites/moodles/im/moodle/lib/outputrenderers.php:1374]
      #10 core_renderer->render_page_layout() called at [/Users/nicols/Sites/moodles/im/moodle/lib/outputrenderers.php:1304]
      #11 core_renderer->header() called at [/Users/nicols/Sites/moodles/im/moodle/mod/forum/view.php:158]
      

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            dobedobedoh Andrew Nicols
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: