Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67097

Identify and fix problems with rtlcss support after css parser upgrade

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Unit tests cover this change, however, we also want to verify that the one case we know to have been affected, is now fixed.
      1. Load up a fresh site on integration master
      2. Run through the steps of MDLQA-14065 and confirm that's all passing.

      Show
      Unit tests cover this change, however, we also want to verify that the one case we know to have been affected, is now fixed. 1. Load up a fresh site on integration master 2. Run through the steps of MDLQA-14065 and confirm that's all passing.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67097-master-2

      Description

      MDL-65759 upgraded the parser.
      lib/rtlcss uses this.

      As a result, video js stopped working on RTL (MDL-66982), as some directives (valid ones) were not being respected any more.

      That issue was closed, but caused a larger RTL issue (MDL-67086).

      This issue is about working out why the css parser upgrade caused this (this was verified via a bisect - before that change the issue in MDL-66982 is not present)

      Edited:
      Note: As part of this issue resolution we need to ensure, apart from understanding why our RTL is so "unestable" and fixing it, that MDL-66982 (RTL videojs) is fixed. Just to avoid forgetting it.

        Attachments

        1. boost1.png
          boost1.png
          187 kB
        2. boost2.png
          boost2.png
          212 kB
        3. classic1.png
          classic1.png
          259 kB
        4. classic2.png
          classic2.png
          184 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 40 minutes
                  5h 40m