Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67097

Identify and fix problems with rtlcss support after css parser upgrade

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 3.8
    • 3.8
    • Libraries
    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-67097-master-2
    • Hide

      Unit tests cover this change, however, we also want to verify that the one case we know to have been affected, is now fixed.
      1. Load up a fresh site on integration master
      2. Run through the steps of MDLQA-14065 and confirm that's all passing.

      Show
      Unit tests cover this change, however, we also want to verify that the one case we know to have been affected, is now fixed. 1. Load up a fresh site on integration master 2. Run through the steps of MDLQA-14065 and confirm that's all passing.

    Description

      MDL-65759 upgraded the parser.
      lib/rtlcss uses this.

      As a result, video js stopped working on RTL (MDL-66982), as some directives (valid ones) were not being respected any more.

      That issue was closed, but caused a larger RTL issue (MDL-67086).

      This issue is about working out why the css parser upgrade caused this (this was verified via a bisect - before that change the issue in MDL-66982 is not present)

      Edited:
      Note: As part of this issue resolution we need to ensure, apart from understanding why our RTL is so "unestable" and fixing it, that MDL-66982 (RTL videojs) is fixed. Just to avoid forgetting it.

      Attachments

        1. boost1.png
          boost1.png
          187 kB
        2. boost2.png
          boost2.png
          212 kB
        3. classic1.png
          classic1.png
          259 kB
        4. classic2.png
          classic2.png
          184 kB

        Issue Links

          blocks

          Functional Test - A test of a single Moodle feature MDLQA-14065 CLONE - In RTL mode the VideoJS progress timeline is not flipped.

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-13827 CLONE - RTL site smoke test

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Passed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-67086 Entire page directionality is broken in RTL

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is a regression caused by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65759 Upgrade Sabberworm/PHP-CSS-Parser to 8.3.0

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jaked Jake Dallimore
              jaked Jake Dallimore
              Peter Dias Peter Dias
              Jun Pataleta Jun Pataleta
              Janelle Barcega Janelle Barcega
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 40 minutes
                  5h 40m