[MDL-67115] Fix known cases of implode() and join() passing glue string after array - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

CiBoT: Verify that all automated tests continue working.

Nothing else: Other than that, I've reviewed manually all implode()/join() occurrences in code base and did not find others requiring this change. If I missed any... we'll know it with use and the fix is trivial, so no problem. I'd not recommend you to look again.
Show
CiBoT: Verify that all automated tests continue working. Nothing else: Other than that, I've reviewed manually all implode()/join() occurrences in code base and did not find others requiring this change. If I missed any... we'll know it with use and the fix is trivial, so no problem. I'd not recommend you to look again.
Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
Prepare Moodle for PHP 7.4
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 3.8 Branch:
~~MDL-67115~~_38
Pull 3.8 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-67115_38~4...MDL-67115_38
Pull Master Branch:
~~MDL-67115~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-67115~4...MDL-67115

. Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).

We'll use unit/acceptance/logs as source for this... hardly can review all the cases (1558), still will try to look for some quoted cases.

has been marked as being related by

MDL-68351 Backport MDL-67374 (Upgrade SimplePie to latest version) to 38_STABLE

is blocked by

MDL-67372 Upgrade HTML Purifier to 4.12.0

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Estimated:

Not Specified

Remaining:

Logged:

4h 41m