Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67115

Fix known cases of implode() and join() passing glue string after array

    XMLWordPrintable

    Details

      Description

      . Passing parameters to implode() in reverse order is deprecated, use
      implode($glue, $parts) instead of implode($parts, $glue).

      We'll use unit/acceptance/logs as source for this... hardly can review all the cases (1558), still will try to look for some quoted cases.

      WIP on this happening @ https://github.com/stronk7/moodle/compare/master...MDL-67115

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stronk7 Eloy Lafuente (stronk7)
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Tim Hunt
                Integrator:
                Jun Pataleta
                Tester:
                CiBoT
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Fix Release Date:
                  9/Mar/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 40 minutes
                  4h 40m