Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67115

Fix known cases of implode() and join() passing glue string after array

    XMLWordPrintable

Details

    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • Hide
      1. CiBoT: Verify that all automated tests continue working.
      2. Nothing else: Other than that, I've reviewed manually all implode()/join() occurrences in code base and did not find others requiring this change. If I missed any... we'll know it with use and the fix is trivial, so no problem. I'd not recommend you to look again.
      Show
      CiBoT: Verify that all automated tests continue working. Nothing else: Other than that, I've reviewed manually all implode()/join() occurrences in code base and did not find others requiring this change. If I missed any... we'll know it with use and the fix is trivial, so no problem. I'd not recommend you to look again.

    Description

      . Passing parameters to implode() in reverse order is deprecated, use
      implode($glue, $parts) instead of implode($parts, $glue).

      We'll use unit/acceptance/logs as source for this... hardly can review all the cases (1558), still will try to look for some quoted cases.

      WIP on this happening @ https://github.com/stronk7/moodle/compare/master...MDL-67115

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Tim Hunt Tim Hunt
              Jun Pataleta Jun Pataleta
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 41 minutes
                  4h 41m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.