Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67116

Make 'require grade' an activity completion criterion for the forum

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Set up

      1. Create a site with a course and at least one student enrolled
        An existing course will be fine - we only need one student for these tests
      2. Log in as admin

      Ratings only grading

      1. Open a course
      2. Turn editing on
      3. Add a glossary activity to the course
        1. Set "Completion tracking" to "Show activity as complete when conditions are met"
        2. Untick all conditions
        3. Confirm that the "Require grade" option is disabled so you cannot check it
      4. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      5. Expand the "Ratings" section
      6. Set "Aggregate type" to "Average of ratings"
        1. Confirm that the "Require grade" option is no longer disabled (but do not select it)
      7. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      8. Check the "Require grade" option
      9. Set "Aggregate type" to "No ratings""
      10. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      11. Set "Aggregate type" to "Average of ratings"
        1. Confirm that the "Require grade" option is no longer disabled
      12. Check the "Require grade" option
      13. Press "Save and display"
        1. Confirm the form saved successfully
      14. Login as a student
      15. Add a new glossary entrty
      16. Log back in as teacher
      17. View the course
      18. From the settings Cog choose "More..."
      19. Open the "Activity completion" report
      20. Find the column for the glossary you created
        1. Confirm that it is unticked for the student
      21. Open the glossary again
      22. Give the student's new entry a rating
      23. Refresh the report
        1. Confirm that the student has now completed the activity
      24. Edit the settings of the activity again
      25. Expand all sections
        1. Confirm that the Ratings Type is locked and cannot be changed
        2. Confirm that all fields under Activity completion are locked and cannot be changed

      Single grade item grading

      1. Open a course
      2. Turn editing on
      3. Add an assignment activity to the course
      4. Expand all sections
        1. Set the "Grade > Type" to "None"
        2. Set "Completion tracking" to "Show activity as complete when conditions are met"
        3. Untick all conditions under "Activity completion"
        4. Confirm that the "Require grade" option is disabled so you cannot check it
      5. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      6. Set the "Grade > Type" to "Point"
        1. Confirm that the "Require grade" option is no longer disabled (but do not select it)
      7. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      8. Check the "Require grade" option
        1. Set the "Grade > Type" to "None"
      9. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      10. Set the "Grade > Type" to "Point"
        1. Confirm that the "Require grade" option is no longer disabled
      11. Check the "Require grade" option
      12. Press "Save and display"
        1. Confirm the form saved successfully
      13. View the activity completion report
      14. Find the column for the assigment you created
        1. Confirm that it is unticked for the student
      15. Open the assignment again
      16. Press "Grade"
      17. Find that student and give them a grade
      18. View the activity completion report
      19. Find the column for the assigment you created
        1. Confirm that it is now ticked for the student

      Ratings and grade item grading

      1. Open a course
      2. Turn editing on
      3. Add a forum activity to the course
      4. Expand all sections
        1. Set the "Whole forum grading > Type" to "None"
        2. Set "Completion tracking" to "Show activity as complete when conditions are met"
        3. Untick all conditions
        4. Ensure that "Activity completion > Require grade" is set to "Grade not required"
      5. Press "Save and display"
        1. Confirm that you are shown a warning that at least one requirement must be met
      6. Choose "Ratings" from "Activity completion > Require grade"
      7. Press "Save and display"
        1. Confirm that you are shown a warning beneath "Require grade":

          Require grade can't be enabled for Rating because grading by Rating is not enabled.

      8. Choose "Whole forum grading" from "Activity completion > Require grade"
      9. Press "Save and display"
        1. Confirm that you are shown a warning beneath "Require grade":

          Require grade can't be enabled for Whole forum grading because grading by Whole forum grading is not enabled.

      10. Set the "Whole forum grading > Type" to "Point"
      11. Choose "Ratings" from "Activity completion > Require grade"
      12. Press "Save and display"
        1. Confirm that you are shown a warning beneath "Require grade":

          Require grade can't be enabled for Rating because grading by Rating is not enabled.

      13. Set the "Whole forum grading > Type" to "None"
      14. Set the "Ratings > Aggregate type" to "Average of ratings"
      15. Choose "Whole forum grading" from "Activity completion > Require grade"
      16. Press "Save and display"
        1. Confirm that you are shown a warning beneath "Require grade":

          Require grade can't be enabled for Whole forum grading because grading by Whole forum grading is not enabled.

      17. Choose "Ratings" from "Activity completion > Require grade"
      18. Press "Save and display"
        1. Confirm the form saved successfully
      19. Create a second forum:
        1. Set "Whole forum grading > Type" to "Point"
        2. Choose "Whole forum grading" from "Activity completion > Require grade"
      20. Press "Save and display"
        1. Confirm the form saved successfully
      21. Log in as a student and create a discussion in both of the forums
      22. Log back in as admin
      23. View the Activity completion report
        1. Confirm that the columns for both of the new forums are unticked for the test user
      24. View the ratings forum
      25. Rate the student's post
      26. View the Activity completion report
        1. Confirm that the column for the Ratings forum is now ticked
      27. View the whole forum graded forum
      28. Grade the student's post
      29. View the Activity completion report
        1. Confirm that the column for the Whole forum graded forum is now ticked
      Show
      Set up Create a site with a course and at least one student enrolled An existing course will be fine - we only need one student for these tests Log in as admin Ratings only grading Open a course Turn editing on Add a glossary activity to the course Set "Completion tracking" to "Show activity as complete when conditions are met" Untick all conditions Confirm that the "Require grade" option is disabled so you cannot check it Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Expand the "Ratings" section Set "Aggregate type" to "Average of ratings" Confirm that the "Require grade" option is no longer disabled (but do not select it) Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Check the "Require grade" option Set "Aggregate type" to "No ratings"" Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Set "Aggregate type" to "Average of ratings" Confirm that the "Require grade" option is no longer disabled Check the "Require grade" option Press "Save and display" Confirm the form saved successfully Login as a student Add a new glossary entrty Log back in as teacher View the course From the settings Cog choose "More..." Open the "Activity completion" report Find the column for the glossary you created Confirm that it is unticked for the student Open the glossary again Give the student's new entry a rating Refresh the report Confirm that the student has now completed the activity Edit the settings of the activity again Expand all sections Confirm that the Ratings Type is locked and cannot be changed Confirm that all fields under Activity completion are locked and cannot be changed Single grade item grading Open a course Turn editing on Add an assignment activity to the course Expand all sections Set the "Grade > Type" to "None" Set "Completion tracking" to "Show activity as complete when conditions are met" Untick all conditions under "Activity completion" Confirm that the "Require grade" option is disabled so you cannot check it Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Set the "Grade > Type" to "Point" Confirm that the "Require grade" option is no longer disabled (but do not select it) Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Check the "Require grade" option Set the "Grade > Type" to "None" Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Set the "Grade > Type" to "Point" Confirm that the "Require grade" option is no longer disabled Check the "Require grade" option Press "Save and display" Confirm the form saved successfully View the activity completion report Find the column for the assigment you created Confirm that it is unticked for the student Open the assignment again Press "Grade" Find that student and give them a grade View the activity completion report Find the column for the assigment you created Confirm that it is now ticked for the student Ratings and grade item grading Open a course Turn editing on Add a forum activity to the course Expand all sections Set the "Whole forum grading > Type" to "None" Set "Completion tracking" to "Show activity as complete when conditions are met" Untick all conditions Ensure that "Activity completion > Require grade" is set to "Grade not required" Press "Save and display" Confirm that you are shown a warning that at least one requirement must be met Choose "Ratings" from "Activity completion > Require grade" Press "Save and display" Confirm that you are shown a warning beneath "Require grade" : Require grade can't be enabled for Rating because grading by Rating is not enabled. Choose "Whole forum grading" from "Activity completion > Require grade" Press "Save and display" Confirm that you are shown a warning beneath "Require grade" : Require grade can't be enabled for Whole forum grading because grading by Whole forum grading is not enabled. Set the "Whole forum grading > Type" to "Point" Choose "Ratings" from "Activity completion > Require grade" Press "Save and display" Confirm that you are shown a warning beneath "Require grade" : Require grade can't be enabled for Rating because grading by Rating is not enabled. Set the "Whole forum grading > Type" to "None" Set the "Ratings > Aggregate type" to "Average of ratings" Choose "Whole forum grading" from "Activity completion > Require grade" Press "Save and display" Confirm that you are shown a warning beneath "Require grade" : Require grade can't be enabled for Whole forum grading because grading by Whole forum grading is not enabled. Choose "Ratings" from "Activity completion > Require grade" Press "Save and display" Confirm the form saved successfully Create a second forum: Set "Whole forum grading > Type" to "Point" Choose "Whole forum grading" from "Activity completion > Require grade" Press "Save and display" Confirm the form saved successfully Log in as a student and create a discussion in both of the forums Log back in as admin View the Activity completion report Confirm that the columns for both of the new forums are unticked for the test user View the ratings forum Rate the student's post View the Activity completion report Confirm that the column for the Ratings forum is now ticked View the whole forum graded forum Grade the student's post View the Activity completion report Confirm that the column for the Whole forum graded forum is now ticked
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67116-master
    • Sprint:
      Internationals - 3.8 Alpha

      Description

      With the new forum grading in 3.8 it makes sense to add "require grade" as a criterion for activity completion, as with assignments and other graded activities.

        Attachments

        1. 67116 - form.png
          159 kB
          Andrew Nicols
        2. 67116 - list.png
          193 kB
          Andrew Nicols
        3. Ratings and grade item grading_confirmed.png
          192 kB
          Gladys Basiana
        4. Ratings only grading_confirmed.png
          165 kB
          Gladys Basiana
        5. Single grade item grading_confirmed.png
          170 kB
          Gladys Basiana

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            marycooch Mary Cooch
            Peer reviewer:
            Mathew May
            Integrator:
            Jun Pataleta
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 7 hours, 1 minute
                2d 7h 1m