Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67122

Forum summary report download does not support filters

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      • Log in as admin.
      • Restore the attached backup into a new course.

      Test

      1. Still logged in as admin, navigate to the new course you have created from the backup.
      2. Open the "Security Education" forum activity.
      3. In the forum actions menu, click "Summary report".
      4. CONFIRM the summary report shows 9 users.
      5. Click on the "Groups" filter button.
      6. Check/select "Blue team" and press "Save".
      7. CONFIRM you now see 4 users.
      8. Below the table, click the "Download" button and either "open with" the file with an appropriate application, or save the file and open it manually. Keep the report page open, as you will need it for the final steps.
      9. CONFIRM the downloaded report only contains the 3 users shown on the report page.
      10. Compare the data shown in the downloaded report to those shown on the report page, and CONFIRM all values match.
      11. Perform another action on the summary report except for downloading the CSV file (e.g. applying another filter or changing the sorting in the columns or pagination size.)
      12. Confirm that the correct action is performed and that the CSV does not get redownloaded
      Show
      Setup Log in as admin. Restore the attached backup into a new course. Test Still logged in as admin, navigate to the new course you have created from the backup. Open the "Security Education" forum activity. In the forum actions menu, click "Summary report". CONFIRM the summary report shows 9 users. Click on the "Groups" filter button. Check/select "Blue team" and press "Save". CONFIRM you now see 4 users. Below the table, click the "Download" button and either "open with" the file with an appropriate application, or save the file and open it manually. Keep the report page open, as you will need it for the final steps. CONFIRM the downloaded report only contains the 3 users shown on the report page. Compare the data shown in the downloaded report to those shown on the report page, and CONFIRM all values match. Perform another action on the summary report except for downloading the CSV file (e.g. applying another filter or changing the sorting in the columns or pagination size.) Confirm that the correct action is performed and that the CSV does not get redownloaded
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67122-master

      Description

      The forum summary report download form submits its own form, and therefore does not pass filter values to TableSQL. The result is that the download always contains the full report and never the filtered version.

      Similar overrides should be applied as other submission links (such as the table headings), and ideally, the sesskey should also be submitted via POST and not GET.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              michaelh Michael Hawkins
              Reporter:
              michaelh Michael Hawkins
              Peer reviewer:
              Simey Lameze
              Integrator:
              Jun Pataleta
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 49 minutes
                  1d 1h 49m