Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67126

In assignment activity the completion state is not set reliably for all group members

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.6.6, 3.7.2, 3.8
    • Fix Version/s: None
    • Labels:
    • Testing Instructions:
      Hide
      1. You must have setup a course with these settings:
        • Create a course
        • Setup a group of least two members
        • As a teacher insert an assignment to the course
        • Set the activity settings "Activity completion" -> "Completion tracking: Show activity as complete when conditions are met" and select only "Student must submit to this activity to complete it".
        • Set the "Students submit in groups" to "Yes"
        • Set the "Require students to click the submit button" to "No"
        • As a member of the group make a submission
        • Access the course of the second member of the group.
      2. Apply the patch and verify that the testcase works as expected.
      3. Checkout the mod/assign/locallib.php and re-run the testcase, it will fail now.
      Show
      You must have setup a course with these settings: Create a course Setup a group of least two members As a teacher insert an assignment to the course Set the activity settings "Activity completion" -> "Completion tracking: Show activity as complete when conditions are met" and select only "Student must submit to this activity to complete it". Set the "Students submit in groups" to "Yes" Set the "Require students to click the submit button" to "No" As a member of the group make a submission Access the course of the second member of the group. Apply the patch and verify that the testcase works as expected. Checkout the mod/assign/locallib.php and re-run the testcase, it will fail now.
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-67126_master

      Description

      The completion state of the activity in assignments are not set when group submission setting is set to "Students submit in groups: Yes" and "Require students to click the submit button: No" then only the submitter will have at the activity completion state set to "Complete".

      To reproduce:

      1. Create a course
      2. Setup a group of least two members
      3. As a teacher insert an assignment to the course
      4. Set the activity settings "Activity completion" -> "Completion tracking: Show activity as complete when conditions are met" and select only "Student must submit to this activity to complete it".
      5. Set the "Students submit in groups" to "Yes"
      6. Set the "Require students to click the submit button" to "No"
      7. As a member of the group make a submission
      8. Access the course of the second member of the group.

      What you expect:

      • The completion state is set to completed

      What actually happens:

      • The completion state is not set as completed

      Remarks:

      • The problem is that the update activity completion record state seems to depending on the "Require students to click the submit button" setting.
      • If it is set to "No" the activity completion records will not be updated for all group members. It only adds and updates the submissions. It uses the process_save_submission function.
      • If it is set to "Yes" the completion records will be set for all group members. In this case it adds and updates the completion states as well. It uses the process_submit_for_grading function.
      • In the test_update_activity_completion_records_team_submission unit test it is always set to update these completion state of all members. Which is not according the normal submit procedure.
      • The normal submit procedure will only run the process_save_submission method, and if the "Require students to click the submit button" is set to "Yes", it will run additionally the process_submit_for_grading method.

        Attachments

          Activity

            People

            • Assignee:
              pead Adrian Perez
              Reporter:
              pead Adrian Perez
              Peer reviewer:
              Peter Dias
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Damyon Wiese, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 11 minutes
                11m