Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67129

Unexpected behaviour on H5P Atto button

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: H5P
    • Labels:
    • Testing Instructions:
      Hide
      • Login as Admin
      • Create a new instance of a Wiki
      • Add a new Wiki page
      • In the Atto editor for the page upload the attached h5p file (ipsum.h5p) using the h5p atto button
      • Verify you see the h5p placeholder after clicking save
      • Place the cursor after the h5p placeholder
      • Type some text
      • Double click the h5p placeholder
      • In the H5P options check some of the checkboxes
      • Click Insert H5P
      • Verify the text you entered underneath the h5p placeholder is still in the same position.
      Show
      Login as Admin Create a new instance of a Wiki Add a new Wiki page In the Atto editor for the page upload the attached h5p file (ipsum.h5p) using the h5p atto button Verify you see the h5p placeholder after clicking save Place the cursor after the h5p placeholder Type some text Double click the h5p placeholder In the H5P options check some of the checkboxes Click Insert H5P Verify the text you entered underneath the h5p placeholder is still in the same position.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67129-master-2
    • Sprint:
      H5P Sprint Relase 3.8

      Description

      The new ATTO H5P button presents some unexpected behaviour when assing a new H5P element:

      Case 1: If the text is empty and you add a new H5P you can write under the H5P but if you add a line break above the H5P element add an empty <div class="h5p-placeholder"><br></div>

       

      Case 2:  Every time that you edit an H5P element (dobleclick on it) and press "Insert H5P" the text below the element goes down one line.

        Attachments

        1. h5p_testing01_2.gif
          141 kB
          Ferran Recio
        2. h5p_testing02_2.gif
          419 kB
          Ferran Recio
        3. image-2019-11-11-09-46-16-440.png
          103 kB
          Janelle Barcega
        4. ipsums.h5p
          529 kB
          Ferran Recio

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            tusefomal Ferran Recio
            Peer reviewer:
            Ferran Recio
            Integrator:
            Adrian Greeve
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 6 hours, 40 minutes
                1d 6h 40m