Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67130

H5P file upload function in the H5P atto button reduces performance on all pages that load atto

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Deferred
    • Affects Version/s: 3.8
    • Fix Version/s: None
    • Component/s: H5P
    • Labels:
      None
    • Affected Branches:
      MOODLE_38_STABLE

      Description

      Discovered after testing MDL-66399:

      The new H5P file upload feature for the H5P atto button reduces performance by adding a few DB queries through lib/form/editor.php

      To replicate

      • Login as admin
      • Turn on performance info for the page footer
      • Create a new forum
      • Create a new forum post
      • View the number of DB reads
      • Comment out the h5p code in lib/form/editor.php
      • View the number of DB reads again

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              basbrands Bas Brands
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: