Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67130

H5P file upload function in the H5P atto button reduces performance on all pages that load atto

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Deferred
    • 3.8
    • None
    • H5P
    • None
    • MOODLE_38_STABLE

    Description

      Discovered after testing MDL-66399:

      The new H5P file upload feature for the H5P atto button reduces performance by adding a few DB queries through lib/form/editor.php

      To replicate

      • Login as admin
      • Turn on performance info for the page footer
      • Create a new forum
      • Create a new forum post
      • View the number of DB reads
      • Comment out the h5p code in lib/form/editor.php
      • View the number of DB reads again

      Attachments

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-66399 Improve H5P Atto button to upload content

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-67128 The performance decrease using new Atto H5P button

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Improvement - An enhancement to an existing Moodle feature. MDL-67127 Create an specific file type for h5p file extension

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              basbrands Bas Brands
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: